Include reviews from `@tornaria`

docs/source/config/details.rst

@@ -33,7 +33,7 b' which defines the defaults. The required interface is like this:'
    Prompt style definition. *shell* is a reference to the
    :class:`~.TerminalInteractiveShell` instance.
 
-   .. method:: in_prompt_tokens(cli=None)
+   .. method:: in_prompt_tokens()
                continuation_prompt_tokens(self, width=None)
                rewrite_prompt_tokens()
                out_prompt_tokens()
@@ -43,8 +43,6 b' which defines the defaults. The required interface is like this:'
       For continuation prompts, *width* is an integer representing the width of
       the prompt area in terminal columns.
 
-      *cli*, where used, is the prompt_toolkit ``CommandLineInterface`` instance.
-      This is mainly for compatibility with the API prompt_toolkit expects.
 
 Here is an example Prompt class that will show the current working directory
 in the input prompt:
@@ -55,7 +53,7 b' in the input prompt:'
     import os
 
     class MyPrompt(Prompts):
-         def in_prompt_tokens(self, cli=None):
+         def in_prompt_tokens(self):
              return [(Token, os.getcwd()),
                      (Token.Prompt, ' >>>')]
 

examples/Embedding/embed_class_long.py

@@ -18,10 +18,11 b' The code in this file is deliberately extra-verbose, meant for learning."""'
 # %run example-embed.py)
 
 from IPython.terminal.prompts import Prompts, Token
+from traitlets.config.loader import Config
 
 class CustomPrompt(Prompts):
 
-    def in_prompt_tokens(self, cli=None):
+    def in_prompt_tokens(self):
 
        return [
             (Token.Prompt, 'In <'),
@@ -37,7 +38,6 b' class CustomPrompt(Prompts):'
         ]
  
 
-from traitlets.config.loader import Config
 try:
     get_ipython
 except NameError:

examples/utils/cwd_prompt.py

@@ -6,9 +6,12 b' import os'
 
 class MyPrompt(Prompts):
 
-     def in_prompt_tokens(self, cli=None):
-         return [(Token, os.getcwd()),
-                 (Token.Prompt, '>>>')]
+    def in_prompt_tokens(self):
+        return [
+                (Token, os.getcwd()),
+                (Token.Prompt, ">>>")
+               ]
+
 
 def load_ipython_extension(shell):
     new_prompts = MyPrompt(shell)
@@ -20,7 +23,3 b' def unload_ipython_extension(shell):'
         print("cannot unload")
     else:
         shell.prompts = shell.prompts.old_prompts
-
-
-
-