upstream/ipython Files · IPython/kernel/core/error.py

Move crash handling to the application level and simplify class structure....

Move crash handling to the application level and simplify class structure. Starting to try to take real advantage of the refactoring, to have generic crash handling. This also lets us initialize the app without needing all the self.attempt() wrappers, since now there's a good system-wide crash handler at the app level (not inside the shell instance). I didn't yet remove the attempt() method because we may have occasional uses for it (we still do, but in one place only). I also removed some extra class layers that weren't quite needed. Creating classes solely for the purpose of passing parameters makes the code (IMO) harder to understand, I kept getting lost in parts of the class hierarchy. I think these changes provide the same flexibility but with easier to follow code (less things to remember, basically). What I tried to do was to use argument passing instead of inheritance for all cases I saw where the inheritance wasn't really adding new functionality. In some cases, this actually allowed me to remove methods that were effectively duplicated in the subclasses.

Brian E Granger - - Load All Authors

File last commit:

r1234:52b55407


                r2403:08d6ac78

Download file

             error.py
        
                    41 lines
            
             | 1.2 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / kernel / core / error.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # encoding: utf-8

      """

      error.py

      We declare here a class hierarchy for all exceptions produced by IPython, in

      cases where we don't just raise one from the standard library.

      """

      __docformat__ = "restructuredtext en"

      #-------------------------------------------------------------------------------

      #  Copyright (C) 2008  The IPython Development Team

      #

      #  Distributed under the terms of the BSD License.  The full license is in

      #  the file COPYING, distributed as part of this software.

      #-------------------------------------------------------------------------------

      #-------------------------------------------------------------------------------

      # Imports

      #-------------------------------------------------------------------------------

      class IPythonError(Exception):

          """Base exception that all of our exceptions inherit from.

          This can be raised by code that doesn't have any more specific

          information."""

          pass

      # Exceptions associated with the controller objects

      class ControllerError(IPythonError): pass

      class ControllerCreationError(ControllerError): pass

      # Exceptions associated with the Engines

      class EngineError(IPythonError): pass

      class EngineCreationError(EngineError): pass

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# encoding: utf-8

				"""
				error.py

				We declare here a class hierarchy for all exceptions produced by IPython, in
				cases where we don't just raise one from the standard library.
				"""

				__docformat__ = "restructuredtext en"

				#-------------------------------------------------------------------------------
				# Copyright (C) 2008 The IPython Development Team
				#
				# Distributed under the terms of the BSD License. The full license is in
				# the file COPYING, distributed as part of this software.
				#-------------------------------------------------------------------------------

				#-------------------------------------------------------------------------------
				# Imports
				#-------------------------------------------------------------------------------


				class IPythonError(Exception):
				"""Base exception that all of our exceptions inherit from.

				This can be raised by code that doesn't have any more specific
				information."""

				pass

				# Exceptions associated with the controller objects
				class ControllerError(IPythonError): pass

				class ControllerCreationError(ControllerError): pass


				# Exceptions associated with the Engines
				class EngineError(IPythonError): pass

				class EngineCreationError(EngineError): pass