##// END OF EJS Templates
Fix inputhook integration - Pass inputhook as an argument to Promptsesion.run(). (#14241)...
Fix inputhook integration - Pass inputhook as an argument to Promptsesion.run(). (#14241) See: https://github.com/prompt-toolkit/python-prompt-toolkit/issues/1809 To summarize: - In prompt_toolkit, some changes were done to get rid of a deprecation warning related to the usage of `set_event_loop()` on Python 3.12. It looks like IPython did had a workaround for the deprecation warning, but Xonsh for instance did not. Now, the code that was fixed in prompt_toolkit breaks input hooks in IPython. - The right thing to do would be to accept the input hook as an argument in prompt_toolkit, which is what this PR does: https://github.com/prompt-toolkit/python-prompt-toolkit/pull/1810 - For IPython, we have to do a similar change to pass it as an argument (this PR). It's not well tested (I'm not using IPython with inputhooks myself). I'm also not very familiar myself with IPython's code base. I think it requires some coordination. I'm not sure if there's a way to be backward compatible. I guess if I push a new prompt_toolkit version with the fix on my side, nothing will break, but input hooks will for sure not work on any Python version until this is merged. We should probably set the minimum prompt_toolkit version after merging this.
Matthias Bussonnier -
r28512:225a1a26 merge
Show More
Name Size Modified Last Commit Author
/ IPython / core / tests
daft_extension
2x2.jpg Loading ...
2x2.png Loading ...
__init__.py Loading ...
bad_all.py Loading ...
nonascii.py Loading ...
nonascii2.py Loading ...
print_argv.py Loading ...
refbug.py Loading ...
simpleerr.py Loading ...
tclass.py Loading ...
test_alias.py Loading ...
test_application.py Loading ...
test_async_helpers.py Loading ...
test_autocall.py Loading ...
test_compilerop.py Loading ...
test_completer.py Loading ...
test_completerlib.py Loading ...
test_debugger.py Loading ...
test_display.py Loading ...
test_displayhook.py Loading ...
test_events.py Loading ...
test_exceptiongroup_tb.py Loading ...
test_extension.py Loading ...
test_formatters.py Loading ...
test_guarded_eval.py Loading ...
test_handlers.py Loading ...
test_history.py Loading ...
test_hooks.py Loading ...
test_imports.py Loading ...
test_inputsplitter.py Loading ...
test_inputtransformer.py Loading ...
test_inputtransformer2.py Loading ...
test_inputtransformer2_line.py Loading ...
test_interactiveshell.py Loading ...
test_iplib.py Loading ...
test_logger.py Loading ...
test_magic.py Loading ...
test_magic_arguments.py Loading ...
test_magic_terminal.py Loading ...
test_oinspect.py Loading ...
test_page.py Loading ...
test_paths.py Loading ...
test_prefilter.py Loading ...
test_profile.py Loading ...
test_prompts.py Loading ...
test_pylabtools.py Loading ...
test_run.py Loading ...
test_shellapp.py Loading ...
test_splitinput.py Loading ...
test_ultratb.py Loading ...