upstream/ipython Files · IPython/core/tests/test_events.py

Remove EventManager reset methods, because they violate encapsulation....

Remove EventManager reset methods, because they violate encapsulation. The whole idea of the EventManager is that you can register hooks without worrying about what hooks other pieces of code might be registering. The reset methods violate this separation of concerns, since they will blow away everyone else's hooks too. (See gh-6680 for an example of this breaking things.) Since there is never any safe way to use them, we simply remove them entirely.

Nathaniel J. Smith - - Load All Authors

File last commit:

r18547:4043b271


                r18547:4043b271

Download file

             test_events.py
        
                    32 lines
            
             | 929 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / core / tests / test_events.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      import unittest

      try:  # Python 3.3 +

          from unittest.mock import Mock

      except ImportError:

          from mock import Mock

      from IPython.core import events

      import IPython.testing.tools as tt

      def ping_received():

          pass

      class CallbackTests(unittest.TestCase):

          def setUp(self):

              self.em = events.EventManager(get_ipython(), {'ping_received': ping_received})

          def test_register_unregister(self):

              cb = Mock()

              self.em.register('ping_received', cb)        

              self.em.trigger('ping_received')

              self.assertEqual(cb.call_count, 1)

              self.em.unregister('ping_received', cb)

              self.em.trigger('ping_received')

              self.assertEqual(cb.call_count, 1)

          def test_cb_error(self):

              cb = Mock(side_effect=ValueError)

              self.em.register('ping_received', cb)

              with tt.AssertPrints("Error in callback"):

                  self.em.trigger('ping_received')

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				import unittest
				try: # Python 3.3 +
				from unittest.mock import Mock
				except ImportError:
				from mock import Mock

				from IPython.core import events
				import IPython.testing.tools as tt

				def ping_received():
				pass

				class CallbackTests(unittest.TestCase):
				def setUp(self):
				self.em = events.EventManager(get_ipython(), {'ping_received': ping_received})

				def test_register_unregister(self):
				cb = Mock()

				self.em.register('ping_received', cb)
				self.em.trigger('ping_received')
				self.assertEqual(cb.call_count, 1)

				self.em.unregister('ping_received', cb)
				self.em.trigger('ping_received')
				self.assertEqual(cb.call_count, 1)

				def test_cb_error(self):
				cb = Mock(side_effect=ValueError)
				self.em.register('ping_received', cb)
				with tt.AssertPrints("Error in callback"):
				self.em.trigger('ping_received')