upstream/ipython Files · IPython/html/kernelspecs/handlers.py

Remove EventManager reset methods, because they violate encapsulation....

Remove EventManager reset methods, because they violate encapsulation. The whole idea of the EventManager is that you can register hooks without worrying about what hooks other pieces of code might be registering. The reset methods violate this separation of concerns, since they will blow away everyone else's hooks too. (See gh-6680 for an example of this breaking things.) Since there is never any safe way to use them, we simply remove them entirely.

Thomas Kluyver - - Load All Authors

File last commit:

r17007:f0064fa0


                r18547:4043b271

Download file

             handlers.py
        
                    26 lines
            
             | 1011 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / html / kernelspecs / handlers.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      from tornado import web

      from ..base.handlers import IPythonHandler

      from ..services.kernelspecs.handlers import kernel_name_regex

      class KernelSpecResourceHandler(web.StaticFileHandler, IPythonHandler):

          SUPPORTED_METHODS = ('GET', 'HEAD')

          def initialize(self):

              web.StaticFileHandler.initialize(self, path='')

          @web.authenticated

          def get(self, kernel_name, path, include_body=True):

              ksm = self.kernel_spec_manager

              try:

                  self.root = ksm.get_kernel_spec(kernel_name).resource_dir

              except KeyError:

                  raise web.HTTPError(404, u'Kernel spec %s not found' % kernel_name)

              self.log.debug("Serving kernel resource from: %s", self.root)

              return web.StaticFileHandler.get(self, path, include_body=include_body)

          @web.authenticated

          def head(self, kernel_name, path):

              self.get(kernel_name, path, include_body=False)

      default_handlers = [

          (r"/kernelspecs/%s/(?P<path>.*)" % kernel_name_regex, KernelSpecResourceHandler),

      ]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				from tornado import web
				from ..base.handlers import IPythonHandler
				from ..services.kernelspecs.handlers import kernel_name_regex

				class KernelSpecResourceHandler(web.StaticFileHandler, IPythonHandler):
				SUPPORTED_METHODS = ('GET', 'HEAD')

				def initialize(self):
				web.StaticFileHandler.initialize(self, path='')

				@web.authenticated
				def get(self, kernel_name, path, include_body=True):
				ksm = self.kernel_spec_manager
				try:
				self.root = ksm.get_kernel_spec(kernel_name).resource_dir
				except KeyError:
				raise web.HTTPError(404, u'Kernel spec %s not found' % kernel_name)
				self.log.debug("Serving kernel resource from: %s", self.root)
				return web.StaticFileHandler.get(self, path, include_body=include_body)

				@web.authenticated
				def head(self, kernel_name, path):
				self.get(kernel_name, path, include_body=False)

				default_handlers = [
				(r"/kernelspecs/%s/(?P<path>.*)" % kernel_name_regex, KernelSpecResourceHandler),
				]