upstream/ipython Files · IPython/core/tests/test_logger.py

Make event triggering robust to (un)registration....

Make event triggering robust to (un)registration. Event callbacks can register or unregister new callbacks for the same event while executing, and the previous triggering implementation allowed for event callbacks to be inadvertently skipped. The fix is to make a copy of the list of callbacks before executing any of them. With this change, the resulting semantics are simple: any callbacks registered before triggering are executed, and any new callbacks registered are only visible at the next triggering of the event. Note that this could potentially break existing callers who expected newly-appended callbacks were immediately executed. Fixes . Originally based on a patch by @marksandler2.

Fernando Perez - - Load All Authors

File last commit:

r7115:a8a64ebc


                r22317:68860ee5

Download file

             test_logger.py
        
                    32 lines
            
             | 917 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / core / tests / test_logger.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # -*- coding: utf-8 -*-

      """Test IPython.core.logger"""

      import os.path

      import nose.tools as nt

      from IPython.utils.tempdir import TemporaryDirectory

      _ip = get_ipython()

      def test_logstart_inaccessible_file():

          try:

              _ip.logger.logstart(logfname="/")   # Opening that filename will fail.

          except IOError:

              pass

          else:

              nt.assert_true(False)           # The try block should never pass.

          try:

              _ip.run_cell("a=1")                 # Check it doesn't try to log this

          finally:

              _ip.logger.log_active = False  # If this fails, don't let later tests fail

      def test_logstart_unicode():

          with TemporaryDirectory() as tdir:

              logfname = os.path.join(tdir, "test_unicode.log")

              _ip.run_cell("'abc€'")

              try:

                  _ip.magic("logstart -to %s" % logfname)

                  _ip.run_cell("'abc€'")

              finally:

                  _ip.logger.logstop()

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# -- coding: utf-8 --
				"""Test IPython.core.logger"""

				import os.path

				import nose.tools as nt
				from IPython.utils.tempdir import TemporaryDirectory

				_ip = get_ipython()

				def test_logstart_inaccessible_file():
				try:
				_ip.logger.logstart(logfname="/") # Opening that filename will fail.
				except IOError:
				pass
				else:
				nt.assert_true(False) # The try block should never pass.

				try:
				_ip.run_cell("a=1") # Check it doesn't try to log this
				finally:
				_ip.logger.log_active = False # If this fails, don't let later tests fail

				def test_logstart_unicode():
				with TemporaryDirectory() as tdir:
				logfname = os.path.join(tdir, "test_unicode.log")
				_ip.run_cell("'abc€'")
				try:
				_ip.magic("logstart -to %s" % logfname)
				_ip.run_cell("'abc€'")
				finally:
				_ip.logger.logstop()