upstream/ipython Files · IPython/utils/tests/test_openpy.py

Handle OSError cases where traceback frames occur from built files (#13964)...

Handle OSError cases where traceback frames occur from built files (#13964) I've been using the `_render_traceback_` method of the traceback object, provided by the `IPython.core.interactiveshell.InteractiveShell` object that you created, in the `showtraceback` method. Thanks to this, I was able to create better error messages. I appreciate it. The following issue is related to the use of this method. ```python try: # Exception classes can customise their traceback - we # use this in IPython.parallel for exceptions occurring # in the engines. This should return a list of strings. if hasattr(value, "_render_traceback_"): stb = value._render_traceback_() else: stb = self.InteractiveTB.structured_traceback( etype, value, tb, tb_offset=tb_offset ) ``` I noticed that in the recent `8.11` version, code was added to generate a traceback when the source code is too long. In this case, if the `etb.tb_frame` object is a built file or something similar, the `inspect.getsourcelines(etb.tb_frame)` method may raise an error. So I implemented a change to set the `max_len` to the minimum value and avoid the following condition when an `OSError` occurs. I think this approach can handle cases where errors occur while using the `inspect.getsourcelines()` method. If there is anything I have done wrong or any procedures I should follow, please let me know. I would greatly appreciate it if you could leave a comment and I will make the necessary changes immediately. Thank you.

Samuel Gaist - - Load All Authors

File last commit:

r26922:9c38a13d


                r28196:92027083

Download file

             test_openpy.py
        
                    38 lines
            
             | 1.2 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / utils / tests / test_openpy.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      import io

      import os.path

      from IPython.utils import openpy

      mydir = os.path.dirname(__file__)

      nonascii_path = os.path.join(mydir, "../../core/tests/nonascii.py")

      def test_detect_encoding():

          with open(nonascii_path, "rb") as f:

              enc, lines = openpy.detect_encoding(f.readline)

          assert enc == "iso-8859-5"

      def test_read_file():

          with io.open(nonascii_path, encoding="iso-8859-5") as f:

              read_specified_enc = f.read()

          read_detected_enc = openpy.read_py_file(nonascii_path, skip_encoding_cookie=False)

          assert read_detected_enc == read_specified_enc

          assert "coding: iso-8859-5" in read_detected_enc

          read_strip_enc_cookie = openpy.read_py_file(

              nonascii_path, skip_encoding_cookie=True

          )

          assert "coding: iso-8859-5" not in read_strip_enc_cookie

      def test_source_to_unicode():

          with io.open(nonascii_path, "rb") as f:

              source_bytes = f.read()

          assert (

              openpy.source_to_unicode(source_bytes, skip_encoding_cookie=False).splitlines()

              == source_bytes.decode("iso-8859-5").splitlines()

          )

          source_no_cookie = openpy.source_to_unicode(source_bytes, skip_encoding_cookie=True)

          assert "coding: iso-8859-5" not in source_no_cookie

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				import io
				import os.path

				from IPython.utils import openpy

				mydir = os.path.dirname(__file__)
				nonascii_path = os.path.join(mydir, "../../core/tests/nonascii.py")


				def test_detect_encoding():
				with open(nonascii_path, "rb") as f:
				enc, lines = openpy.detect_encoding(f.readline)
				assert enc == "iso-8859-5"


				def test_read_file():
				with io.open(nonascii_path, encoding="iso-8859-5") as f:
				read_specified_enc = f.read()
				read_detected_enc = openpy.read_py_file(nonascii_path, skip_encoding_cookie=False)
				assert read_detected_enc == read_specified_enc
				assert "coding: iso-8859-5" in read_detected_enc

				read_strip_enc_cookie = openpy.read_py_file(
				nonascii_path, skip_encoding_cookie=True
				)
				assert "coding: iso-8859-5" not in read_strip_enc_cookie


				def test_source_to_unicode():
				with io.open(nonascii_path, "rb") as f:
				source_bytes = f.read()
				assert (
				openpy.source_to_unicode(source_bytes, skip_encoding_cookie=False).splitlines()
				== source_bytes.decode("iso-8859-5").splitlines()
				)

				source_no_cookie = openpy.source_to_unicode(source_bytes, skip_encoding_cookie=True)
				assert "coding: iso-8859-5" not in source_no_cookie