upstream/ipython Files · IPython/utils/tests/test_tempdir.py

Handle OSError cases where traceback frames occur from built files (#13964)...

Handle OSError cases where traceback frames occur from built files (#13964) I've been using the `_render_traceback_` method of the traceback object, provided by the `IPython.core.interactiveshell.InteractiveShell` object that you created, in the `showtraceback` method. Thanks to this, I was able to create better error messages. I appreciate it. The following issue is related to the use of this method. ```python try: # Exception classes can customise their traceback - we # use this in IPython.parallel for exceptions occurring # in the engines. This should return a list of strings. if hasattr(value, "_render_traceback_"): stb = value._render_traceback_() else: stb = self.InteractiveTB.structured_traceback( etype, value, tb, tb_offset=tb_offset ) ``` I noticed that in the recent `8.11` version, code was added to generate a traceback when the source code is too long. In this case, if the `etb.tb_frame` object is a built file or something similar, the `inspect.getsourcelines(etb.tb_frame)` method may raise an error. So I implemented a change to set the `max_len` to the minimum value and avoid the following condition when an `OSError` occurs. I think this approach can handle cases where errors occur while using the `inspect.getsourcelines()` method. If there is anything I have done wrong or any procedures I should follow, please let me know. I would greatly appreciate it if you could leave a comment and I will make the necessary changes immediately. Thank you.

Nikita Kniazev - - Load All Authors

File last commit:

r27126:8e428a71


                r28196:92027083

Download file

             test_tempdir.py
        
                    29 lines
            
             | 1.1 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / utils / tests / test_tempdir.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #-----------------------------------------------------------------------------

      #  Copyright (C) 2012-  The IPython Development Team

      #

      #  Distributed under the terms of the BSD License.  The full license is in

      #  the file COPYING, distributed as part of this software.

      #-----------------------------------------------------------------------------

      from pathlib import Path

      from IPython.utils.tempdir import NamedFileInTemporaryDirectory

      from IPython.utils.tempdir import TemporaryWorkingDirectory

      def test_named_file_in_temporary_directory():

          with NamedFileInTemporaryDirectory('filename') as file:

              name = file.name

              assert not file.closed

              assert Path(name).exists()

              file.write(b'test')

          assert file.closed

          assert not Path(name).exists()

      def test_temporary_working_directory():

          with TemporaryWorkingDirectory() as directory:

              directory_path = Path(directory).resolve()

              assert directory_path.exists()

              assert Path.cwd().resolve() == directory_path

          assert not directory_path.exists()

          assert Path.cwd().resolve() != directory_path

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#-----------------------------------------------------------------------------
				# Copyright (C) 2012- The IPython Development Team
				#
				# Distributed under the terms of the BSD License. The full license is in
				# the file COPYING, distributed as part of this software.
				#-----------------------------------------------------------------------------

				from pathlib import Path

				from IPython.utils.tempdir import NamedFileInTemporaryDirectory
				from IPython.utils.tempdir import TemporaryWorkingDirectory


				def test_named_file_in_temporary_directory():
				with NamedFileInTemporaryDirectory('filename') as file:
				name = file.name
				assert not file.closed
				assert Path(name).exists()
				file.write(b'test')
				assert file.closed
				assert not Path(name).exists()

				def test_temporary_working_directory():
				with TemporaryWorkingDirectory() as directory:
				directory_path = Path(directory).resolve()
				assert directory_path.exists()
				assert Path.cwd().resolve() == directory_path
				assert not directory_path.exists()
				assert Path.cwd().resolve() != directory_path