upstream/ipython Files · IPython/core/macro.py

Fix CVE-2023-24816 by removing legacy code....

Fix CVE-2023-24816 by removing legacy code. Remove legacy code that might trigger a CVE. Currently set_term_title is only called with (semi-)trusted input that contain the current working directory of the current IPython session. If an attacker can control directory names, and manage to get a user cd into this directory the attacker can execute arbitrary commands contained in the folder names. Example: - On a windows machine where python is built without _ctypes, create a folder called && echo "pwn" > pwn.txt. This can be done by for example cloning a git repository. - call toggled_set_term_title(True), (or have the preference to true) - Open IPython and cd into this directory. - the folder now contain a pwn.txt, with pwn as content, despite the user not asking for any code execution. Workaround: Set the configuration option c.TerminalInteractiveShell.term_title_format='IPython' (or to any other fixed, safe string).

Srinivas Reddy Thatiparthy - - Load All Authors

File last commit:

r23699:adf10a5a


                r28089:991849c2

Download file

             macro.py
        
                    53 lines
            
             | 1.7 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / core / macro.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      """Support for interactive macros in IPython"""

      #*****************************************************************************

      #       Copyright (C) 2001-2005 Fernando Perez <fperez@colorado.edu>

      #

      #  Distributed under the terms of the BSD License.  The full license is in

      #  the file COPYING, distributed as part of this software.

      #*****************************************************************************

      import re

      from IPython.utils.encoding import DEFAULT_ENCODING

      coding_declaration = re.compile(r"#\s*coding[:=]\s*([-\w.]+)")

      class Macro(object):

          """Simple class to store the value of macros as strings.

          Macro is just a callable that executes a string of IPython

          input when called.

          """

          def __init__(self,code):

              """store the macro value, as a single string which can be executed"""

              lines = []

              enc = None

              for line in code.splitlines():

                  coding_match = coding_declaration.match(line)

                  if coding_match:

                      enc = coding_match.group(1)

                  else:

                      lines.append(line)

              code = "\n".join(lines)

              if isinstance(code, bytes):

                  code = code.decode(enc or DEFAULT_ENCODING)

              self.value = code + '\n'

          def __str__(self):

              return self.value

          def __repr__(self):

              return 'IPython.macro.Macro(%s)' % repr(self.value)

          def __getstate__(self):

              """ needed for safe pickling via %store """

              return {'value': self.value}

          def __add__(self, other):

              if isinstance(other, Macro):

                  return Macro(self.value + other.value)

              elif isinstance(other, str):

                  return Macro(self.value + other)

              raise TypeError

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				"""Support for interactive macros in IPython"""

				#*****************************************************************************
				# Copyright (C) 2001-2005 Fernando Perez <fperez@colorado.edu>
				#
				# Distributed under the terms of the BSD License. The full license is in
				# the file COPYING, distributed as part of this software.
				#*****************************************************************************

				import re

				from IPython.utils.encoding import DEFAULT_ENCODING

				coding_declaration = re.compile(r"#\scoding[:=]\s([-\w.]+)")

				class Macro(object):
				"""Simple class to store the value of macros as strings.

				Macro is just a callable that executes a string of IPython
				input when called.
				"""

				def __init__(self,code):
				"""store the macro value, as a single string which can be executed"""
				lines = []
				enc = None
				for line in code.splitlines():
				coding_match = coding_declaration.match(line)
				if coding_match:
				enc = coding_match.group(1)
				else:
				lines.append(line)
				code = "\n".join(lines)
				if isinstance(code, bytes):
				code = code.decode(enc or DEFAULT_ENCODING)
				self.value = code + '\n'

				def __str__(self):
				return self.value

				def __repr__(self):
				return 'IPython.macro.Macro(%s)' % repr(self.value)

				def __getstate__(self):
				""" needed for safe pickling via %store """
				return {'value': self.value}

				def __add__(self, other):
				if isinstance(other, Macro):
				return Macro(self.value + other.value)
				elif isinstance(other, str):
				return Macro(self.value + other)
				raise TypeError