upstream/ipython Files · IPython/core/tests/test_page.py

Fix CVE-2023-24816 by removing legacy code....

Fix CVE-2023-24816 by removing legacy code. Remove legacy code that might trigger a CVE. Currently set_term_title is only called with (semi-)trusted input that contain the current working directory of the current IPython session. If an attacker can control directory names, and manage to get a user cd into this directory the attacker can execute arbitrary commands contained in the folder names. Example: - On a windows machine where python is built without _ctypes, create a folder called && echo "pwn" > pwn.txt. This can be done by for example cloning a git repository. - call toggled_set_term_title(True), (or have the preference to true) - Open IPython and cd into this directory. - the folder now contain a pwn.txt, with pwn as content, despite the user not asking for any code execution. Workaround: Set the configuration option c.TerminalInteractiveShell.term_title_format='IPython' (or to any other fixed, safe string).

Matthias BUSSONNIER - - Load All Authors

File last commit:

r5390:c82649ea


                r28089:991849c2

Download file

             test_page.py
        
                    20 lines
            
             | 772 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / core / tests / test_page.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #-----------------------------------------------------------------------------

      #  Copyright (C) 2010-2011 The IPython Development Team.

      #

      #  Distributed under the terms of the BSD License.

      #

      #  The full license is in the file COPYING.txt, distributed with this software.

      #-----------------------------------------------------------------------------

      import io

      # N.B. For the test suite, page.page is overridden (see IPython.testing.globalipapp)

      from IPython.core import page

      def test_detect_screen_size():

          """Simple smoketest for page._detect_screen_size."""

          try:

              page._detect_screen_size(True, 25)

          except (TypeError, io.UnsupportedOperation):

              # This can happen in the test suite, because stdout may not have a

              # fileno.

              pass

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#-----------------------------------------------------------------------------
				# Copyright (C) 2010-2011 The IPython Development Team.
				#
				# Distributed under the terms of the BSD License.
				#
				# The full license is in the file COPYING.txt, distributed with this software.
				#-----------------------------------------------------------------------------
				import io

				# N.B. For the test suite, page.page is overridden (see IPython.testing.globalipapp)
				from IPython.core import page

				def test_detect_screen_size():
				"""Simple smoketest for page._detect_screen_size."""
				try:
				page._detect_screen_size(True, 25)
				except (TypeError, io.UnsupportedOperation):
				# This can happen in the test suite, because stdout may not have a
				# fileno.
				pass