upstream/ipython Files · IPython/core/tests/test_prompts.py

Fix CVE-2023-24816 by removing legacy code....

Fix CVE-2023-24816 by removing legacy code. Remove legacy code that might trigger a CVE. Currently set_term_title is only called with (semi-)trusted input that contain the current working directory of the current IPython session. If an attacker can control directory names, and manage to get a user cd into this directory the attacker can execute arbitrary commands contained in the folder names. Example: - On a windows machine where python is built without _ctypes, create a folder called && echo "pwn" > pwn.txt. This can be done by for example cloning a git repository. - call toggled_set_term_title(True), (or have the preference to true) - Open IPython and cd into this directory. - the folder now contain a pwn.txt, with pwn as content, despite the user not asking for any code execution. Workaround: Set the configuration option c.TerminalInteractiveShell.term_title_format='IPython' (or to any other fixed, safe string).

Matthias Bussonnier - - Load All Authors

File last commit:

r25094:59d93919


                r28089:991849c2

Download file

             test_prompts.py
        
                    30 lines
            
             | 845 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / core / tests / test_prompts.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # -*- coding: utf-8

      """Tests for prompt generation."""

      import unittest

      from IPython.core.prompts import  LazyEvaluate

      class PromptTests(unittest.TestCase):

          def test_lazy_eval_unicode(self):

              u = u'ünicødé'

              lz = LazyEvaluate(lambda : u)

              self.assertEqual(str(lz), u)

              self.assertEqual(format(lz), u)

          def test_lazy_eval_nonascii_bytes(self):

              u = u'ünicødé'

              b = u.encode('utf8')

              lz = LazyEvaluate(lambda : b)

              # unicode(lz) would fail

              self.assertEqual(str(lz), str(b))

              self.assertEqual(format(lz), str(b))

          def test_lazy_eval_float(self):

              f = 0.503

              lz = LazyEvaluate(lambda : f)

              self.assertEqual(str(lz), str(f))

              self.assertEqual(format(lz), str(f))

              self.assertEqual(format(lz, '.1'), '0.5')

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# -*- coding: utf-8
				"""Tests for prompt generation."""

				import unittest

				from IPython.core.prompts import LazyEvaluate

				class PromptTests(unittest.TestCase):
				def test_lazy_eval_unicode(self):
				u = u'ünicødé'
				lz = LazyEvaluate(lambda : u)
				self.assertEqual(str(lz), u)
				self.assertEqual(format(lz), u)

				def test_lazy_eval_nonascii_bytes(self):
				u = u'ünicødé'
				b = u.encode('utf8')
				lz = LazyEvaluate(lambda : b)
				# unicode(lz) would fail
				self.assertEqual(str(lz), str(b))
				self.assertEqual(format(lz), str(b))

				def test_lazy_eval_float(self):
				f = 0.503
				lz = LazyEvaluate(lambda : f)

				self.assertEqual(str(lz), str(f))
				self.assertEqual(format(lz), str(f))
				self.assertEqual(format(lz, '.1'), '0.5')