upstream/ipython Files · IPython/utils/tests/test_tempdir.py

Fix CVE-2023-24816 by removing legacy code....

Fix CVE-2023-24816 by removing legacy code. Remove legacy code that might trigger a CVE. Currently set_term_title is only called with (semi-)trusted input that contain the current working directory of the current IPython session. If an attacker can control directory names, and manage to get a user cd into this directory the attacker can execute arbitrary commands contained in the folder names. Example: - On a windows machine where python is built without _ctypes, create a folder called && echo "pwn" > pwn.txt. This can be done by for example cloning a git repository. - call toggled_set_term_title(True), (or have the preference to true) - Open IPython and cd into this directory. - the folder now contain a pwn.txt, with pwn as content, despite the user not asking for any code execution. Workaround: Set the configuration option c.TerminalInteractiveShell.term_title_format='IPython' (or to any other fixed, safe string).

Nikita Kniazev - - Load All Authors

File last commit:

r27126:8e428a71


                r28089:991849c2

Download file

             test_tempdir.py
        
                    29 lines
            
             | 1.1 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / utils / tests / test_tempdir.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #-----------------------------------------------------------------------------

      #  Copyright (C) 2012-  The IPython Development Team

      #

      #  Distributed under the terms of the BSD License.  The full license is in

      #  the file COPYING, distributed as part of this software.

      #-----------------------------------------------------------------------------

      from pathlib import Path

      from IPython.utils.tempdir import NamedFileInTemporaryDirectory

      from IPython.utils.tempdir import TemporaryWorkingDirectory

      def test_named_file_in_temporary_directory():

          with NamedFileInTemporaryDirectory('filename') as file:

              name = file.name

              assert not file.closed

              assert Path(name).exists()

              file.write(b'test')

          assert file.closed

          assert not Path(name).exists()

      def test_temporary_working_directory():

          with TemporaryWorkingDirectory() as directory:

              directory_path = Path(directory).resolve()

              assert directory_path.exists()

              assert Path.cwd().resolve() == directory_path

          assert not directory_path.exists()

          assert Path.cwd().resolve() != directory_path

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#-----------------------------------------------------------------------------
				# Copyright (C) 2012- The IPython Development Team
				#
				# Distributed under the terms of the BSD License. The full license is in
				# the file COPYING, distributed as part of this software.
				#-----------------------------------------------------------------------------

				from pathlib import Path

				from IPython.utils.tempdir import NamedFileInTemporaryDirectory
				from IPython.utils.tempdir import TemporaryWorkingDirectory


				def test_named_file_in_temporary_directory():
				with NamedFileInTemporaryDirectory('filename') as file:
				name = file.name
				assert not file.closed
				assert Path(name).exists()
				file.write(b'test')
				assert file.closed
				assert not Path(name).exists()

				def test_temporary_working_directory():
				with TemporaryWorkingDirectory() as directory:
				directory_path = Path(directory).resolve()
				assert directory_path.exists()
				assert Path.cwd().resolve() == directory_path
				assert not directory_path.exists()
				assert Path.cwd().resolve() != directory_path