upstream/ipython Files · IPython/core/tests/test_hooks.py

Use single quotes in sql string literal (#13968)...

Use single quotes in sql string literal (#13968) the SQL spec requires that string literals use single quotes and column references (or other identifiers) use double quotes. sqlite permits the use of double quotes for string literals in "unambiguous cases". For some reason, its understanding of what constitutes unambiguous has changed recently - I'm on FreeBSD 14.0-CURRENT with sqlite 3.41.0 - and attempting to do anything with ipython throws a very strange sqlite operation error: ``` [+] ~% ipython --version (test) audrey@daisy [12:18:02 AM] 8.11.0 [+] ~% ipython (test) audrey@daisy [12:18:04 AM] [TerminalIPythonApp] ERROR | Failed to create history session in /usr/home/audrey/.ipython/profile_default/history.sqlite. History will not be saved. Traceback (most recent call last): File "/usr/home/audrey/.virtualenvs/test/lib/python3.9/site-packages/IPython/core/history.py", line 545, in __init__ self.new_session() File "/usr/home/audrey/.virtualenvs/test/lib/python3.9/site-packages/decorator.py", line 232, in fun return caller(func, *(extras + args), **kw) File "/usr/home/audrey/.virtualenvs/test/lib/python3.9/site-packages/IPython/core/history.py", line 60, in only_when_enabled return f(self, *a, **kw) File "/usr/home/audrey/.virtualenvs/test/lib/python3.9/site-packages/IPython/core/history.py", line 570, in new_session cur = conn.execute("""INSERT INTO sessions VALUES (NULL, ?, NULL, sqlite3.OperationalError: no such column: Python 3.9.16 (main, Feb 28 2023, 01:31:45) Type 'copyright', 'credits' or 'license' for more information IPython 8.11.0 -- An enhanced Interactive Python. Type '?' for help. ``` This patch fixes it. idk if this constitutes a bug in sqlite3, but this is, I guess, more correct.

Nikita Kniazev - - Load All Authors

File last commit:

r27087:0e59ae55


                r28168:9a5baf06

Download file

             test_hooks.py
        
                    76 lines
            
             | 2.3 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / core / tests / test_hooks.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # -*- coding: utf-8 -*-

      """Tests for CommandChainDispatcher."""

      #-----------------------------------------------------------------------------

      # Imports

      #-----------------------------------------------------------------------------

      import pytest

      from IPython.core.error import TryNext

      from IPython.core.hooks import CommandChainDispatcher

      #-----------------------------------------------------------------------------

      # Local utilities

      #-----------------------------------------------------------------------------

      # Define two classes, one which succeeds and one which raises TryNext. Each

      # sets the attribute `called` to True when it is called.

      class Okay(object):

          def __init__(self, message):

              self.message = message

              self.called = False

          def __call__(self):

              self.called = True

              return self.message

      class Fail(object):

          def __init__(self, message):

              self.message = message

              self.called = False

          def __call__(self):

              self.called = True

              raise TryNext(self.message)

      #-----------------------------------------------------------------------------

      # Test functions

      #-----------------------------------------------------------------------------

      def test_command_chain_dispatcher_ff():

          """Test two failing hooks"""

          fail1 = Fail("fail1")

          fail2 = Fail("fail2")

          dp = CommandChainDispatcher([(0, fail1), (10, fail2)])

          with pytest.raises(TryNext) as e:

              dp()

          assert str(e.value) == "fail2"

          assert fail1.called is True

          assert fail2.called is True

      def test_command_chain_dispatcher_fofo():

          """Test a mixture of failing and succeeding hooks."""

          fail1 = Fail("fail1")

          fail2 = Fail("fail2")

          okay1 = Okay("okay1")

          okay2 = Okay("okay2")

          dp = CommandChainDispatcher([(0, fail1),

                                       # (5, okay1), # add this later

                                       (10, fail2),

                                       (15, okay2)])

          dp.add(okay1, 5)

          assert dp() == "okay1"

          assert fail1.called is True

          assert okay1.called is True

          assert fail2.called is False

          assert okay2.called is False

      def test_command_chain_dispatcher_eq_priority():

          okay1 = Okay(u'okay1')

          okay2 = Okay(u'okay2')

          dp = CommandChainDispatcher([(1, okay1)])

          dp.add(okay2, 1)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# -- coding: utf-8 --
				"""Tests for CommandChainDispatcher."""


				#-----------------------------------------------------------------------------
				# Imports
				#-----------------------------------------------------------------------------

				import pytest
				from IPython.core.error import TryNext
				from IPython.core.hooks import CommandChainDispatcher

				#-----------------------------------------------------------------------------
				# Local utilities
				#-----------------------------------------------------------------------------

				# Define two classes, one which succeeds and one which raises TryNext. Each
				# sets the attribute `called` to True when it is called.
				class Okay(object):
				def __init__(self, message):
				self.message = message
				self.called = False
				def __call__(self):
				self.called = True
				return self.message

				class Fail(object):
				def __init__(self, message):
				self.message = message
				self.called = False
				def __call__(self):
				self.called = True
				raise TryNext(self.message)

				#-----------------------------------------------------------------------------
				# Test functions
				#-----------------------------------------------------------------------------

				def test_command_chain_dispatcher_ff():
				"""Test two failing hooks"""
				fail1 = Fail("fail1")
				fail2 = Fail("fail2")
				dp = CommandChainDispatcher([(0, fail1), (10, fail2)])

				with pytest.raises(TryNext) as e:
				dp()
				assert str(e.value) == "fail2"

				assert fail1.called is True
				assert fail2.called is True

				def test_command_chain_dispatcher_fofo():
				"""Test a mixture of failing and succeeding hooks."""
				fail1 = Fail("fail1")
				fail2 = Fail("fail2")
				okay1 = Okay("okay1")
				okay2 = Okay("okay2")

				dp = CommandChainDispatcher([(0, fail1),
				# (5, okay1), # add this later
				(10, fail2),
				(15, okay2)])
				dp.add(okay1, 5)

				assert dp() == "okay1"

				assert fail1.called is True
				assert okay1.called is True
				assert fail2.called is False
				assert okay2.called is False

				def test_command_chain_dispatcher_eq_priority():
				okay1 = Okay(u'okay1')
				okay2 = Okay(u'okay2')
				dp = CommandChainDispatcher([(1, okay1)])
				dp.add(okay2, 1)