upstream/ipython Files · IPython/lib/tests/test_editorhooks.py

`AssertionError`: `assert _xterm_term_title_saved` in WSL (#14480)...

`AssertionError`: `assert _xterm_term_title_saved` in WSL (#14480) `AssertionError`: `assert _xterm_term_title_saved` In some (unknown) situation, it is possible that the `_xterm_term_title_saved` is unset, but the code would make a call to `_restore_term_title_xterm`, resulting in `AssertionError`. At least on replicatable reproduction is returning from `ipython` to `pudb` via `^D^D` on an empty cell. See more details in https://github.com/ipython/ipython/pull/14480 Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com> <details> <summary><em>was:</em></summary> In some (unknown) situation, it is possible that the `_xterm_term_title_saved` is unset, but the code would make a call to `_restore_term_title_xterm`, resulting in `AssertionError`. As title stacking does not seem to be getting traction (https://github.com/microsoft/terminal/issues/14575), do not set the `xterm` variants of `_set_term_title` / `_restore_term_title`. WSL detection: https://superuser.com/a/1749811/533196 Additionally, almost-`black` the file. </details>

Matthias Bussonnier - - Load All Authors

File last commit:

r26716:4142eaaf


                r28838:9b8cd4a3

Download file

             test_editorhooks.py
        
                    32 lines
            
             | 884 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / lib / tests / test_editorhooks.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      """Test installing editor hooks"""

      import sys

      from unittest import mock

      from IPython import get_ipython

      from IPython.lib import editorhooks

      def test_install_editor():

          called = []

          def fake_popen(*args, **kwargs):

              called.append({

                  'args': args,

                  'kwargs': kwargs,

              })

              return mock.MagicMock(**{'wait.return_value': 0})

          editorhooks.install_editor('foo -l {line} -f {filename}', wait=False)

          with mock.patch('subprocess.Popen', fake_popen):

              get_ipython().hooks.editor('the file', 64)

          assert len(called) == 1

          args = called[0]["args"]

          kwargs = called[0]["kwargs"]

          assert kwargs == {"shell": True}

          if sys.platform.startswith("win"):

              expected = ["foo", "-l", "64", "-f", "the file"]

          else:

              expected = "foo -l 64 -f 'the file'"

          cmd = args[0]

          assert cmd == expected

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				"""Test installing editor hooks"""
				import sys
				from unittest import mock

				from IPython import get_ipython
				from IPython.lib import editorhooks

				def test_install_editor():
				called = []
				def fake_popen(args, *kwargs):
				called.append({
				'args': args,
				'kwargs': kwargs,
				})
				return mock.MagicMock(**{'wait.return_value': 0})
				editorhooks.install_editor('foo -l {line} -f {filename}', wait=False)

				with mock.patch('subprocess.Popen', fake_popen):
				get_ipython().hooks.editor('the file', 64)

				assert len(called) == 1
				args = called[0]["args"]
				kwargs = called[0]["kwargs"]

				assert kwargs == {"shell": True}

				if sys.platform.startswith("win"):
				expected = ["foo", "-l", "64", "-f", "the file"]
				else:
				expected = "foo -l 64 -f 'the file'"
				cmd = args[0]
				assert cmd == expected