upstream/ipython Files · IPython/lib/tests/test_editorhooks.py

Backport PR : IPython/lib/editorhooks.py: wait for process even if wait=False...

Backport PR : IPython/lib/editorhooks.py: wait for process even if wait=False The wait parameter is meant to add a prompt before returning from the hook for editors that exit immediatly (fork/CreateProcess) but it accidently prevented waiting at all for the process when it was False. I think it was meant to be `not wait and proc.wait()` but we might as well wait for the process in the `wait=True` case anyhow. It's less confusing. It would be nice if this is backported to 5.x.

Thomas Kluyver - - Load All Authors

File last commit:

r23301:a29fa80e


                r23301:a29fa80e

Download file

             test_editorhooks.py
        
                    38 lines
            
             | 987 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / lib / tests / test_editorhooks.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      """Test installing editor hooks"""

      import sys

      try:

          import mock

      except ImportError:

          from unittest import mock

      import nose.tools as nt

      from IPython import get_ipython

      from IPython.lib import editorhooks

      def test_install_editor():

          called = []

          def fake_popen(*args, **kwargs):

              called.append({

                  'args': args,

                  'kwargs': kwargs,

              })

              return mock.MagicMock(**{'wait.return_value': 0})

          editorhooks.install_editor('foo -l {line} -f {filename}', wait=False)

          with mock.patch('subprocess.Popen', fake_popen):

              get_ipython().hooks.editor('the file', 64)

          nt.assert_equal(len(called), 1)

          args = called[0]['args']

          kwargs = called[0]['kwargs']

          nt.assert_equal(kwargs, {'shell': True})

          if sys.platform.startswith('win'):

              expected = ['foo', '-l', '64', '-f', 'the file']

          else:

              expected = "foo -l 64 -f 'the file'"

          cmd = args[0]

          nt.assert_equal(cmd, expected)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				"""Test installing editor hooks"""
				import sys

				try:
				import mock
				except ImportError:
				from unittest import mock

				import nose.tools as nt

				from IPython import get_ipython
				from IPython.lib import editorhooks

				def test_install_editor():
				called = []
				def fake_popen(args, *kwargs):
				called.append({
				'args': args,
				'kwargs': kwargs,
				})
				return mock.MagicMock(**{'wait.return_value': 0})
				editorhooks.install_editor('foo -l {line} -f {filename}', wait=False)

				with mock.patch('subprocess.Popen', fake_popen):
				get_ipython().hooks.editor('the file', 64)

				nt.assert_equal(len(called), 1)
				args = called[0]['args']
				kwargs = called[0]['kwargs']

				nt.assert_equal(kwargs, {'shell': True})

				if sys.platform.startswith('win'):
				expected = ['foo', '-l', '64', '-f', 'the file']
				else:
				expected = "foo -l 64 -f 'the file'"
				cmd = args[0]
				nt.assert_equal(cmd, expected)