##// END OF EJS Templates
Fix #4777 and #7887...
Fix #4777 and #7887 The function in charge of actually converting cursor offset to CodeMirror line number and character number was actually crashing when the cursor was at the last character (loop until undefined, then access length of variable, which is undefined). This was hiding a bug in which when you would completer to a single completion pressing tab after as-you-type filtering, the completion would be completed twice. The logic that was supposed to detect whether or not all completions had a common prefix was actually faulty as the common prefix used to be a string but was then changed to an object. Hence the logic to check whether or not there was actually a common prefix was always true, even for empty string, leading to the deletion of the line (replace by '') in some cases.

File last commit:

r20312:948690df
r20538:ae7f6d6a
Show More
edit.html
99 lines | 3.4 KiB | text/html | HtmlLexer
{% extends "page.html" %}
{% block title %}{{page_title}}{% endblock %}
{% block stylesheet %}
<link rel="stylesheet" href="{{ static_url('components/codemirror/lib/codemirror.css') }}">
<link rel="stylesheet" href="{{ static_url('components/codemirror/addon/dialog/dialog.css') }}">
{{super()}}
{% endblock %}
{% block bodyclasses %}edit_app {{super()}}{% endblock %}
{% block params %}
data-base-url="{{base_url}}"
data-file-path="{{file_path}}"
{{super()}}
{% endblock %}
{% block headercontainer %}
<span id="save_widget" class="pull-left save_widget">
<span class="filename"></span>
<span class="last_modified"></span>
</span>
{% endblock %}
{% block header %}
<div id="menubar-container" class="container">
<div id="menubar">
<div id="menus" class="navbar navbar-default" role="navigation">
<div class="container-fluid">
<p class="navbar-text indicator_area">
<span id="current-mode" >current mode</span>
</p>
<button type="button" class="btn btn-default navbar-toggle" data-toggle="collapse" data-target=".navbar-collapse">
<i class="fa fa-bars"></i>
<span class="navbar-text">Menu</span>
</button>
<ul class="nav navbar-nav navbar-right">
<li id="notification_area"></li>
</ul>
<div class="navbar-collapse collapse">
<ul class="nav navbar-nav">
<li class="dropdown"><a href="#" class="dropdown-toggle" data-toggle="dropdown">File</a>
<ul id="file-menu" class="dropdown-menu">
<li id="new-file"><a href="#">New</a></li>
<li id="save-file"><a href="#">Save</a></li>
<li id="rename-file"><a href="#">Rename</a></li>
<li id="download-file"><a href="#">Download</a></li>
</ul>
</li>
<li class="dropdown"><a href="#" class="dropdown-toggle" data-toggle="dropdown">Edit</a>
<ul id="edit-menu" class="dropdown-menu">
<li id="menu-find"><a href="#">Find</a></li>
<li id="menu-replace"><a href="#">Find &amp; Replace</a></li>
<li class="divider"></li>
<li class="dropdown-header">Key Map</li>
<li id="menu-keymap-default"><a href="#">Default<i class="fa"></i></a></li>
<li id="menu-keymap-sublime"><a href="#">Sublime Text<i class="fa"></i></a></li>
<li id="menu-keymap-vim"><a href="#">Vim<i class="fa"></i></a></li>
<li id="menu-keymap-emacs"><a href="#">emacs<i class="fa"></i></a></li>
</ul>
</li>
<li class="dropdown"><a href="#" class="dropdown-toggle" data-toggle="dropdown">View</a>
<ul id="view-menu" class="dropdown-menu">
<li id="menu-line-numbers"><a href="#">Toggle Line Numbers</a></li>
</ul>
</li>
<li class="dropdown"><a href="#" class="dropdown-toggle" data-toggle="dropdown">Language</a>
<ul id="mode-menu" class="dropdown-menu">
</ul>
</li>
</ul>
</div>
</div>
</div>
</div>
</div>
<div class="lower-header-bar"></div>
{% endblock %}
{% block site %}
<div id="texteditor-backdrop">
<div id="texteditor-container" class="container"></div>
</div>
{% endblock %}
{% block script %}
{{super()}}
<script src="{{ static_url("edit/js/main.js") }}" type="text/javascript" charset="utf-8"></script>
{% endblock %}