##// END OF EJS Templates
Fix #4777 and #7887...
Fix #4777 and #7887 The function in charge of actually converting cursor offset to CodeMirror line number and character number was actually crashing when the cursor was at the last character (loop until undefined, then access length of variable, which is undefined). This was hiding a bug in which when you would completer to a single completion pressing tab after as-you-type filtering, the completion would be completed twice. The logic that was supposed to detect whether or not all completions had a common prefix was actually faulty as the common prefix used to be a string but was then changed to an object. Hence the logic to check whether or not there was actually a common prefix was always true, even for empty string, leading to the deletion of the line (replace by '') in some cases.

File last commit:

r15439:37fe6ef6
r20538:ae7f6d6a
Show More
base.py
54 lines | 2.0 KiB | text/x-python | PythonLexer
"""Base TestCase class for testing Exporters"""
#-----------------------------------------------------------------------------
# Copyright (c) 2013, the IPython Development Team.
#
# Distributed under the terms of the Modified BSD License.
#
# The full license is in the file COPYING.txt, distributed with this software.
#-----------------------------------------------------------------------------
#-----------------------------------------------------------------------------
# Imports
#-----------------------------------------------------------------------------
import os
from IPython.testing.decorators import onlyif_any_cmd_exists
from ...tests.base import TestsBase
#-----------------------------------------------------------------------------
# Class
#-----------------------------------------------------------------------------
all_raw_mimetypes = {
'text/x-python',
'text/markdown',
'text/html',
'text/restructuredtext',
'text/latex',
}
class ExportersTestsBase(TestsBase):
"""Contains base test functions for exporters"""
exporter_class = None
should_include_raw = None
def _get_notebook(self, nb_name='notebook2.ipynb'):
return os.path.join(self._get_files_path(), nb_name)
@onlyif_any_cmd_exists('nodejs', 'node', 'pandoc')
def test_raw_cell_inclusion(self):
"""test raw cell inclusion based on raw_mimetype metadata"""
if self.should_include_raw is None:
return
exporter = self.exporter_class()
(output, resources) = exporter.from_filename(self._get_notebook('rawtest.ipynb'))
for inc in self.should_include_raw:
self.assertIn('raw %s' % inc, output, "should include %s" % inc)
self.assertIn('no raw_mimetype metadata', output)
for exc in all_raw_mimetypes.difference(self.should_include_raw):
self.assertNotIn('raw %s' % exc, output, "should exclude %s" % exc)
self.assertNotIn('never be included', output)