upstream/ipython Files · IPython/core/tests/test_logger.py

validate ESC_PAREN ('/') is followed by a callable name and not empty (#12690)...

validate ESC_PAREN ('/') is followed by a callable name and not empty (#12690) When running a single python expression with just a slash - `/`, a tuple is returned. ```python In [1]: / Out[1]: () ``` This weird case happens because when a line starts with `/` the `inputtransformer` transforms it into a call of the first word after the `/` as the callable name and rest tokens after as arguments. This PR fixes that issue by validating that at least a callable name is given and it's not empty, if not a `SyntaxError` will be raised. ```python In [1]: / File "<ipython-input-1-8f27084b6294>", line 1 / ^ SyntaxError: invalid syntax In [2]: ``` Validated that tests are passing.

Matthias Bussonnier - - Load All Authors

File last commit:

r27509:42e22f8e


                r28936:b65cf89c

Download file

             test_logger.py
        
                    27 lines
            
             | 776 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / core / tests / test_logger.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # -*- coding: utf-8 -*-

      """Test IPython.core.logger"""

      import os.path

      import pytest

      from tempfile import TemporaryDirectory

      def test_logstart_inaccessible_file():

          with pytest.raises(IOError):

              _ip.logger.logstart(logfname="/")   # Opening that filename will fail.

          try:

              _ip.run_cell("a=1")                 # Check it doesn't try to log this

          finally:

              _ip.logger.log_active = False  # If this fails, don't let later tests fail

      def test_logstart_unicode():

          with TemporaryDirectory() as tdir:

              logfname = os.path.join(tdir, "test_unicode.log")

              _ip.run_cell("'abc€'")

              try:

                  _ip.magic("logstart -to %s" % logfname)

                  _ip.run_cell("'abc€'")

              finally:

                  _ip.logger.logstop()

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# -- coding: utf-8 --
				"""Test IPython.core.logger"""

				import os.path

				import pytest
				from tempfile import TemporaryDirectory


				def test_logstart_inaccessible_file():
				with pytest.raises(IOError):
				_ip.logger.logstart(logfname="/") # Opening that filename will fail.

				try:
				_ip.run_cell("a=1") # Check it doesn't try to log this
				finally:
				_ip.logger.log_active = False # If this fails, don't let later tests fail

				def test_logstart_unicode():
				with TemporaryDirectory() as tdir:
				logfname = os.path.join(tdir, "test_unicode.log")
				_ip.run_cell("'abc€'")
				try:
				_ip.magic("logstart -to %s" % logfname)
				_ip.run_cell("'abc€'")
				finally:
				_ip.logger.logstop()