##// END OF EJS Templates
Swallow potential exceptions from showtraceback() (#13934)...
Swallow potential exceptions from showtraceback() (#13934) The nbgrader project is aware of a form of cheating where students disrupt `InteractiveShell.showtraceback` in hopes of hiding exceptions to avoid losing points. They have implemented a solution to prevent this cheating from working on the client side, and have some tests to demonstrate this technique: https://github.com/jupyter/nbgrader/blob/main/nbgrader/tests/apps/files/submitted-cheat-attempt.ipynb https://github.com/jupyter/nbgrader/blob/main/nbgrader/tests/apps/files/submitted-cheat-attempt-alternative.ipynb In essence, these attacks import the interactive shell and erase the traceback handler so that their failing tests won't report failures. ```python import IPython.core.interactiveshell IPython.core.interactiveshell.InteractiveShell.showtraceback = None ``` The problem is that this causes an exception inside the kernel, leading to a stalled execution. The kernel has stopped working, but the client continues to wait for messages. So far, nbgrader's solution to this is to require a timeout value so the client can eventually decide it is done. This prevents allowing a value of `None` for `Execute.timeout` because this would cause a test case to infinitely hang. This commit addresses the problem by making `InteractiveShell._run_cell` a little more protective around it's call to `showtraceback()`. There is already a try/except block around running the cell. This commit adds a finally clause so that the method will _always_ return an `ExecutionResult`, even if a new exception is thrown within the except clause. For the record, the exception thrown is: TypeError: 'NoneType' object is not callable Accepting this change will allow nbgrader to update `nbgrader.preprocessors.Execute` to support a type of `Integer(allow_none=True)` as the parent `NotebookClient` intended. Discussion about this is ongoing in jupyter/nbgrader#1690.
Matthias Bussonnier -
r28101:e548ee23 merge
Show More
Name Size Modified Last Commit Author
/ docs
man
source
sphinxext
Makefile Loading ...
README.rst Loading ...
autogen_api.py Loading ...
autogen_config.py Loading ...
autogen_magics.py Loading ...
autogen_shortcuts.py Loading ...
environment.yml Loading ...
make.cmd Loading ...
requirements.txt Loading ...

IPython Documentation

This directory contains the majority of the documentation for IPython.

Deploy docs

Documentation is automatically deployed on ReadTheDocs on every push or merged Pull requests.

Requirements

The documentation must be built using Python 3.

In addition to :ref:`devinstall`, the following tools are needed to build the documentation:

  • sphinx
  • sphinx_rtd_theme
  • docrepr

In a conda environment, or a Python 3 venv, you should be able to run:

cd ipython
pip install .[doc] -U

Build Commands

The documentation gets built using make, and comes in several flavors.

make html - build the API and narrative documentation web pages, this is the default make target, so running just make is equivalent to make html.

make html_noapi - same as above, but without running the auto-generated API docs. When you are working on the narrative documentation, the most time consuming portion of the build process is the processing and rendering of the API documentation. This build target skips that.

make pdf will compile a pdf from the documentation.

You can run make help to see information on all possible make targets.

To save time, the make targets above only process the files that have been changed since the previous docs build. To remove the previous docs build you can use make clean. You can also combine clean with other make commands; for example, make clean html will do a complete rebuild of the docs or make clean pdf will do a complete build of the pdf.

Continuous Integration

Documentation builds are included in the Travis-CI continuous integration process, so you can see the results of the docs build for any pull request at https://travis-ci.org/ipython/ipython/pull_requests.