upstream/ipython Files · IPython/utils/importstring.py

Fix a bug in renaming notebook...

Fix a bug in renaming notebook There was a bug in NotebookManager.save_notebook_object. Here is how to reproduce: 0. Make sure you don't have Untitled0. 1. Open new notebook Untitled0. 2. Rename it to something else. 3. Copy Untitled0.ipynb to the notebook dir from somewhere. (Do not use notebook UI.) 4. New copied Untitled0 cannot be opened. The renamed notebook is opened when tried. Indeed, accessing to http://localhost:XXXX/notebooks shows duplicated notebook_id. The problem was that NotebookManager.rev_mapping keeps old notebook name after renaming.

Fernando Perez - - Load All Authors

File last commit:

r6738:271b4cd3


                r7359:ef719b62

Download file

             importstring.py
        
                    47 lines
            
             | 1.6 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / IPython / utils / importstring.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # encoding: utf-8

      """

      A simple utility to import something by its string name.

      Authors:

      * Brian Granger

      """

      #-----------------------------------------------------------------------------

      #  Copyright (C) 2008-2011  The IPython Development Team

      #

      #  Distributed under the terms of the BSD License.  The full license is in

      #  the file COPYING, distributed as part of this software.

      #-----------------------------------------------------------------------------

      #-----------------------------------------------------------------------------

      # Functions and classes

      #-----------------------------------------------------------------------------

      def import_item(name):

          """Import and return bar given the string foo.bar."""

          package = '.'.join(name.split('.')[0:-1])

          obj = name.split('.')[-1]

          # Note: the original code for this was the following.  We've left it

          # visible for now in case the new implementation shows any problems down

          # the road, to make it easier on anyone looking for a problem.  This code

          # should be removed once we're comfortable we didn't break anything.

          ## execString = 'from %s import %s' % (package, obj)

          ## try:

          ##     exec execString

          ## except SyntaxError:

          ##     raise ImportError("Invalid class specification: %s" % name)

          ## exec 'temp = %s' % obj

          ## return temp

          if package:

              module = __import__(package,fromlist=[obj])

              try:

                  pak = module.__dict__[obj]

              except KeyError:

                  raise ImportError('No module named %s' % obj)

              return pak

          else:

              return __import__(obj)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# encoding: utf-8
				"""
				A simple utility to import something by its string name.

				Authors:

				* Brian Granger
				"""

				#-----------------------------------------------------------------------------
				# Copyright (C) 2008-2011 The IPython Development Team
				#
				# Distributed under the terms of the BSD License. The full license is in
				# the file COPYING, distributed as part of this software.
				#-----------------------------------------------------------------------------

				#-----------------------------------------------------------------------------
				# Functions and classes
				#-----------------------------------------------------------------------------

				def import_item(name):
				"""Import and return bar given the string foo.bar."""
				package = '.'.join(name.split('.')[0:-1])
				obj = name.split('.')[-1]

				# Note: the original code for this was the following. We've left it
				# visible for now in case the new implementation shows any problems down
				# the road, to make it easier on anyone looking for a problem. This code
				# should be removed once we're comfortable we didn't break anything.

				## execString = 'from %s import %s' % (package, obj)
				## try:
				## exec execString
				## except SyntaxError:
				## raise ImportError("Invalid class specification: %s" % name)
				## exec 'temp = %s' % obj
				## return temp

				if package:
				module = __import__(package,fromlist=[obj])
				try:
				pak = module.__dict__[obj]
				except KeyError:
				raise ImportError('No module named %s' % obj)
				return pak
				else:
				return __import__(obj)