upstream/kallithea Files · rhodecode/templates/pullrequests/pullrequest_show_all.html

follow Python conventions for boolean values...

follow Python conventions for boolean values True and False might be singletons and the "default" values for "boolean" expressions, but "all" values in Python has a boolean value and should be evaluated as such. Checking with 'is True' and 'is False' is thus confusing, error prone and unnessarily complex. If we anywhere rely and nullable boolean fields from the database layer and don't want the null value to be treated as False then we should check explicitly for null with 'is None'.

Mads Kiilerich - - Load All Authors

File last commit:

r3609:2ea981f9 beta


                r3625:260a7a01

beta

Download file

             pullrequest_show_all.html
        
                    42 lines
            
             | 1.3 KiB
            
                | text/html
            
             |
                HtmlLexer
            
             / rhodecode / templates / pullrequests / pullrequest_show_all.html
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        marcink
    
- pull request generates overview based on it's params...

              r2440
            
      <%inherit file="/base/base.html"/>

      <%def name="title()">

        marcink
    
improved title consistency...

              r3582
            
          ${_('%s Pull Requests') % c.repo_name} &middot; ${c.rhodecode_name}

        marcink
    
- pull request generates overview based on it's params...

              r2440
            
      </%def>

      <%def name="breadcrumbs_links()">

        Leonardo
    
Fixing missing icons....

              r3532
            
          ${_('Pull requests')}

        marcink
    
- pull request generates overview based on it's params...

              r2440
            
      </%def>

        Mads Kiilerich
    
templates: enforce more consistency by being less flexible in templates...

              r3609
            
      <%def name="page_nav()">

          ${self.menu('repositories')}

      </%def>

        marcink
    
- pull request generates overview based on it's params...

              r2440
            
      <%def name="main()">

        Leonardo
    
Adding the context bar too all pages related to a Repository....

              r3527
            
      ${self.context_bar('showpullrequest')}

        marcink
    
- pull request generates overview based on it's params...

              r2440
            
      <div class="box">

          <!-- box / title -->

          <div class="title">

              ${self.breadcrumbs()}

          </div>

        marcink
    
white space cleanup

              r2478
            
        marcink
    
- pull request generates overview based on it's params...

              r2440
            
          %for pr in c.pull_requests:

        marcink
    
little love for pull-requests list

              r2586
            
              <div>

        marcink
    
some formatting  on list of pull-requests

              r3259
            
                <h4  style="border:0px;padding:0px">

                  %if pr.is_closed():

        marcink
    
show status of pull requests and if it's closed

              r3263
            
                      <img src="${h.url('/images/icons/lock_go.png')}" title="${_('Closed')}"/>

        marcink
    
some formatting  on list of pull-requests

              r3259
            
                  %endif

        marcink
    
show status of pull requests and if it's closed

              r3263
            
                  <img src="${h.url('/images/icons/flag_status_%s.png' % str(pr.last_review_status))}" />

        marcink
    
some formatting  on list of pull-requests

              r3259
            
                  <a href="${h.url('pullrequest_show',repo_name=c.repo_name,pull_request_id=pr.pull_request_id)}">

                  ${_('Pull request #%s opened by %s on %s') % (pr.pull_request_id, pr.author.full_name, h.fmt_date(pr.created_on))}

                  </a>

        marcink
    
little love for pull-requests list

              r2586
            
                </h4>

                <h5 style="border:0px;padding-bottom:0px">${_('Title')}: ${pr.title}</h5>

                <div style="padding:0px 24px">${pr.description}</div>

        marcink
    
some formatting  on list of pull-requests

              r3259
            
                <div style="border-bottom: 1px solid #DDD;margin:10px 20px;padding-bottom:10px"></div>

        marcink
    
little love for pull-requests list

              r2586
            
              </div>

        marcink
    
- pull request generates overview based on it's params...

              r2440
            
          %endfor

        marcink
    
white space cleanup

              r2478
            
        marcink
    
- pull request generates overview based on it's params...

              r2440
            
      </div>

      </%def>

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

marcink - pull request generates overview based on it's params...	r2440	<%inherit file="/base/base.html"/>

		<%def name="title()">
marcink improved title consistency...	r3582	${_('%s Pull Requests') % c.repo_name} · ${c.rhodecode_name}
marcink - pull request generates overview based on it's params...	r2440	</%def>

		<%def name="breadcrumbs_links()">
Leonardo Fixing missing icons....	r3532	${_('Pull requests')}
marcink - pull request generates overview based on it's params...	r2440	</%def>

Mads Kiilerich templates: enforce more consistency by being less flexible in templates...	r3609	<%def name="page_nav()">
		${self.menu('repositories')}
		</%def>

marcink - pull request generates overview based on it's params...	r2440	<%def name="main()">
Leonardo Adding the context bar too all pages related to a Repository....	r3527	${self.context_bar('showpullrequest')}
marcink - pull request generates overview based on it's params...	r2440	<div class="box">
		<!-- box / title -->
		<div class="title">
		${self.breadcrumbs()}
		</div>
marcink white space cleanup	r2478
marcink - pull request generates overview based on it's params...	r2440	%for pr in c.pull_requests:
marcink little love for pull-requests list	r2586	<div>
marcink some formatting on list of pull-requests	r3259	<h4 style="border:0px;padding:0px">
		%if pr.is_closed():
marcink show status of pull requests and if it's closed	r3263	<img src="${h.url('/images/icons/lock_go.png')}" title="${_('Closed')}"/>
marcink some formatting on list of pull-requests	r3259	%endif
marcink show status of pull requests and if it's closed	r3263	<img src="${h.url('/images/icons/flag_status_%s.png' % str(pr.last_review_status))}" />
marcink some formatting on list of pull-requests	r3259	<a href="${h.url('pullrequest_show',repo_name=c.repo_name,pull_request_id=pr.pull_request_id)}">
		${_('Pull request #%s opened by %s on %s') % (pr.pull_request_id, pr.author.full_name, h.fmt_date(pr.created_on))}
		</a>
marcink little love for pull-requests list	r2586	</h4>
		<h5 style="border:0px;padding-bottom:0px">${_('Title')}: ${pr.title}</h5>
		<div style="padding:0px 24px">${pr.description}</div>
marcink some formatting on list of pull-requests	r3259	<div style="border-bottom: 1px solid #DDD;margin:10px 20px;padding-bottom:10px"></div>
marcink little love for pull-requests list	r2586	</div>
marcink - pull request generates overview based on it's params...	r2440	%endfor
marcink white space cleanup	r2478
marcink - pull request generates overview based on it's params...	r2440	</div>

		</%def>