##// END OF EJS Templates
DRY !
DRY !

File last commit:

r2677:4fbbc65e beta
r2738:ddd7a802 beta
Show More
changeset_status.py
188 lines | 6.9 KiB | text/x-python | PythonLexer
dummy ChangesetStatus model
r2216 # -*- coding: utf-8 -*-
"""
rhodecode.model.changeset_status
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:created_on: Apr 30, 2012
:author: marcink
:copyright: (C) 2011-2012 Marcin Kuzminski <marcin@python-works.com>
:license: GPLv3, see COPYING for more details.
"""
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
import logging
Adde pull request voting recalculation
r2481 from collections import defaultdict
dummy ChangesetStatus model
r2216
from rhodecode.model import BaseModel
- pull request generates overview based on it's params...
r2440 from rhodecode.model.db import ChangesetStatus, PullRequest
Forbid changing changset status when it is associated with a closed pull request...
r2677 from rhodecode.lib.exceptions import StatusChangeOnClosedPullRequestError
dummy ChangesetStatus model
r2216
log = logging.getLogger(__name__)
class ChangesetStatusModel(BaseModel):
Added associated classes into child models
r2522 cls = ChangesetStatus
dummy ChangesetStatus model
r2216 def __get_changeset_status(self, changeset_status):
return self._get_instance(ChangesetStatus, changeset_status)
- pull request generates overview based on it's params...
r2440 def __get_pull_request(self, pull_request):
return self._get_instance(PullRequest, pull_request)
Adde pull request voting recalculation
r2481 def _get_status_query(self, repo, revision, pull_request,
with_revisions=False):
repo = self._get_repo(repo)
q = ChangesetStatus.query()\
.filter(ChangesetStatus.repo == repo)
if not with_revisions:
q = q.filter(ChangesetStatus.version == 0)
if revision:
q = q.filter(ChangesetStatus.revision == revision)
elif pull_request:
pull_request = self.__get_pull_request(pull_request)
q = q.filter(ChangesetStatus.pull_request == pull_request)
else:
raise Exception('Please specify revision or pull_request')
q.order_by(ChangesetStatus.version.asc())
return q
def calculate_status(self, statuses_by_reviewers):
"""
leading one wins, if number of occurences are equal than weaker wins
:param statuses_by_reviewers:
"""
status = None
votes = defaultdict(int)
reviewers_number = len(statuses_by_reviewers)
for user, statuses in statuses_by_reviewers:
if statuses:
ver, latest = statuses[0]
votes[latest.status] += 1
else:
votes[ChangesetStatus.DEFAULT] += 1
if votes.get(ChangesetStatus.STATUS_APPROVED) == reviewers_number:
return ChangesetStatus.STATUS_APPROVED
else:
return ChangesetStatus.STATUS_UNDER_REVIEW
def get_statuses(self, repo, revision=None, pull_request=None,
with_revisions=False):
q = self._get_status_query(repo, revision, pull_request,
with_revisions)
return q.all()
- pull request generates overview based on it's params...
r2440 def get_status(self, repo, revision=None, pull_request=None):
Implemented initial code-review status of changesets
r2217 """
- pull request generates overview based on it's params...
r2440 Returns latest status of changeset for given revision or for given
pull request. Statuses are versioned inside a table itself and
version == 0 is always the current one
Implemented initial code-review status of changesets
r2217
:param repo:
:type repo:
- pull request generates overview based on it's params...
r2440 :param revision: 40char hash or None
Implemented initial code-review status of changesets
r2217 :type revision: str
- pull request generates overview based on it's params...
r2440 :param pull_request: pull_request reference
:type:
Implemented initial code-review status of changesets
r2217 """
Adde pull request voting recalculation
r2481 q = self._get_status_query(repo, revision, pull_request)
- pull request generates overview based on it's params...
r2440
- added commenting to pull requests...
r2443 # need to use first here since there can be multiple statuses
# returned from pull_request
status = q.first()
Implemented initial code-review status of changesets
r2217 status = status.status if status else status
st = status or ChangesetStatus.DEFAULT
return str(st)
- added commenting to pull requests...
r2443 def set_status(self, repo, status, user, comment, revision=None,
Forbid changing changset status when it is associated with a closed pull request...
r2677 pull_request=None, dont_allow_on_closed_pull_request=False):
Implemented initial code-review status of changesets
r2217 """
Added simple versioning for changeset status
r2287 Creates new status for changeset or updates the old ones bumping their
version, leaving the current status at
Implemented initial code-review status of changesets
r2217
:param repo:
:type repo:
:param revision:
:type revision:
:param status:
:type status:
:param user:
:type user:
Show changes of status inside comments...
r2286 :param comment:
:type comment:
Forbid changing changset status when it is associated with a closed pull request...
r2677 :param dont_allow_on_closed_pull_request: don't allow a status change
if last status was for pull request and it's closed. We shouldn't
mess around this manually
Implemented initial code-review status of changesets
r2217 """
Share common getter functions in base model, and remove duplicated functions from other models
r2432 repo = self._get_repo(repo)
Implemented initial code-review status of changesets
r2217
- added commenting to pull requests...
r2443 q = ChangesetStatus.query()
if revision:
q = q.filter(ChangesetStatus.repo == repo)
q = q.filter(ChangesetStatus.revision == revision)
elif pull_request:
pull_request = self.__get_pull_request(pull_request)
q = q.filter(ChangesetStatus.repo == pull_request.org_repo)
q = q.filter(ChangesetStatus.pull_request == pull_request)
cur_statuses = q.all()
Forbid changing changset status when it is associated with a closed pull request...
r2677 #if statuses exists and last is associated with a closed pull request
# we need to check if we can allow this status change
if (dont_allow_on_closed_pull_request and cur_statuses
and cur_statuses[0].pull_request.status == PullRequest.STATUS_CLOSED):
raise StatusChangeOnClosedPullRequestError(
'Changing status on closed pull request is not allowed'
)
Added simple versioning for changeset status
r2287 if cur_statuses:
for st in cur_statuses:
st.version += 1
self.sa.add(st)
- added commenting to pull requests...
r2443
def _create_status(user, repo, status, comment, revision, pull_request):
new_status = ChangesetStatus()
new_status.author = self._get_user(user)
new_status.repo = self._get_repo(repo)
new_status.status = status
new_status.comment = comment
new_status.revision = revision
new_status.pull_request = pull_request
return new_status
Implemented initial code-review status of changesets
r2217
- added commenting to pull requests...
r2443 if revision:
new_status = _create_status(user=user, repo=repo, status=status,
white space cleanup
r2478 comment=comment, revision=revision,
- added commenting to pull requests...
r2443 pull_request=None)
self.sa.add(new_status)
return new_status
elif pull_request:
#pull request can have more than one revision associated to it
#we need to create new version for each one
new_statuses = []
repo = pull_request.org_repo
for rev in pull_request.revisions:
new_status = _create_status(user=user, repo=repo,
status=status, comment=comment,
revision=rev,
pull_request=pull_request)
new_statuses.append(new_status)
self.sa.add(new_status)
return new_statuses