##// END OF EJS Templates
pullrequest: just replace children of other_ref when other_repo changes...
pullrequest: just replace children of other_ref when other_repo changes We were inserting a full select statement as innerHTML of a select and would thus get nested select statements. IE did not render that correctly ... and other browsers did strange things. Instead we now create a in memory DOM object and move the optgroups. After appending children to the selector we have to set selectedIndex on all browsers.

File last commit:

r3512:ff3f10a6 beta
r3512:ff3f10a6 beta
Show More
pullrequest.html
204 lines | 7.8 KiB | text/html | HtmlLexer
pull requests draft UI
r2244 <%inherit file="/base/base.html"/>
<%def name="title()">
Added basic models for saving open pull requests...
r2434 ${c.repo_name} ${_('New pull request')}
pull requests draft UI
r2244 </%def>
<%def name="breadcrumbs_links()">
Takumi IINO
i18n 'Home' in breadcrumbs
r2492 ${h.link_to(_(u'Home'),h.url('/'))}
pull requests draft UI
r2244 &raquo;
unified breadcrumbs display
r3392 ${h.repo_link(c.rhodecode_db_repo.groups_and_repo)}
pull requests draft UI
r2244 &raquo;
unified breadcrumbs display
r3392 ${_('new pull request')}
pull requests draft UI
r2244 </%def>
<%def name="main()">
<div class="box">
<!-- box / title -->
<div class="title">
${self.breadcrumbs()}
</div>
Added basic models for saving open pull requests...
r2434 ${h.form(url('pullrequest', repo_name=c.repo_name), method='post', id='pull_request_form')}
<div style="float:left;padding:0px 30px 30px 30px">
pull requests draft UI
r2244 ##ORG
<div style="float:left">
Mads Kiilerich
pull request: don't show fake path with owner names - and owner avatars is also not relevant
r3330 <div>
pull requests draft UI
r2244 <span style="font-size: 20px">
Mads Kiilerich
pull request: select 'tip' by default ... and show what it means right now
r3329 ${h.select('org_repo','',c.org_repos,class_='refs')}:${h.select('org_ref',c.default_org_ref,c.org_refs,class_='refs')}
pull requests draft UI
r2244 </span>
notifications changes...
r3430 <div style="padding:5px 3px 3px 20px;">${c.rhodecode_db_repo.description}</div>
pull requests draft UI
r2244 </div>
<div style="clear:both;padding-top: 10px"></div>
</div>
<div style="float:left;font-size:24px;padding:0px 20px">
created pull-request overview
r2395 <img height=32 width=32 src="${h.url('/images/arrow_right_64.png')}"/>
pull requests draft UI
r2244 </div>
Added basic models for saving open pull requests...
r2434
pull requests draft UI
r2244 ##OTHER, most Probably the PARENT OF THIS FORK
<div style="float:left">
Mads Kiilerich
pull request: don't show fake path with owner names - and owner avatars is also not relevant
r3330 <div>
pull requests draft UI
r2244 <span style="font-size: 20px">
Mads Kiilerich
pull request: move code around and rename default variables
r3327 ${h.select('other_repo',c.default_other_repo,c.other_repos,class_='refs')}:${h.select('other_ref',c.default_other_ref,c.default_other_refs,class_='refs')}
pull requests draft UI
r2244 </span>
notifications changes...
r3430 <div id="other_repo_desc" style="padding:5px 3px 3px 20px;"></div>
pull requests draft UI
r2244 </div>
<div style="clear:both;padding-top: 10px"></div>
</div>
Added basic models for saving open pull requests...
r2434 <div style="clear:both;padding-top: 10px"></div>
## overview pulled by ajax
<div style="float:left" id="pull_request_overview"></div>
added link for detailed overview in pull-request form
r2396 <div style="float:left;clear:both;padding:10px 10px 10px 0px;display:none">
<a id="pull_request_overview_url" href="#">${_('Detailed compare view')}</a>
Added basic models for saving open pull requests...
r2434 </div>
pull requests draft UI
r2244 </div>
created pull-request overview
r2395 <div style="float:left; border-left:1px dashed #eee">
<h4>${_('Pull request reviewers')}</h4>
<div id="reviewers" style="padding:0px 0px 0px 15px">
Added autocomplete widget for pull request reviewers, in exchange of 90s style...
r2612 ## members goes here !
<div class="group_members_wrap">
<ul id="review_members" class="group_members">
%for member in c.review_members:
added option to remove members added using autocomplete widget from pull...
r2613 <li id="reviewer_${member.user_id}">
<div class="reviewers_member">
<div class="gravatar"><img alt="gravatar" src="${h.gravatar_url(member.email,14)}"/> </div>
<div style="float:left">${member.full_name} (${_('owner')})</div>
<input type="hidden" value="${member.user_id}" name="review_members" />
review members are dynamically changed based on selected other_repo owner...
r3388 <span class="delete_icon action_button" onclick="removeReviewMember(${member.user_id})"></span>
added option to remove members added using autocomplete widget from pull...
r2613 </div>
</li>
Added autocomplete widget for pull request reviewers, in exchange of 90s style...
r2612 %endfor
</ul>
white space cleanup
r2673 </div>
Added autocomplete widget for pull request reviewers, in exchange of 90s style...
r2612 <div class='ac'>
<div class="reviewer_ac">
${h.text('user', class_='yui-ac-input')}
<span class="help-block">${_('Add reviewer to this pull request.')}</span>
white space cleanup
r2673 <div id="reviewers_container"></div>
Added autocomplete widget for pull request reviewers, in exchange of 90s style...
r2612 </div>
</div>
created pull-request overview
r2395 </div>
Added basic models for saving open pull requests...
r2434 </div>
created pull-request overview
r2395 <h3>${_('Create new pull request')}</h3>
Added basic models for saving open pull requests...
r2434
pull requests draft UI
r2244 <div class="form">
<!-- fields -->
<div class="fields">
<div class="field">
<div class="label">
<label for="pullrequest_title">${_('Title')}:</label>
</div>
<div class="input">
${h.text('pullrequest_title',size=30)}
</div>
</div>
<div class="field">
<div class="label label-textarea">
<label for="pullrequest_desc">${_('description')}:</label>
</div>
<div class="textarea text-area editor">
${h.textarea('pullrequest_desc',size=30)}
</div>
</div>
<div class="buttons">
removed deprecated ui-button
r2607 ${h.submit('save',_('Send pull request'),class_="ui-btn large")}
${h.reset('reset',_('Reset'),class_="ui-btn large")}
pull requests draft UI
r2244 </div>
</div>
</div>
Added basic models for saving open pull requests...
r2434 ${h.end_form()}
pull requests draft UI
r2244 </div>
created pull-request overview
r2395 <script type="text/javascript">
Added autocomplete widget for pull request reviewers, in exchange of 90s style...
r2612 var _USERS_AC_DATA = ${c.users_array|n};
var _GROUPS_AC_DATA = ${c.users_groups_array|n};
PullRequestAutoComplete('user', 'reviewers_container', _USERS_AC_DATA, _GROUPS_AC_DATA);
Added dynamic data loading for other repo we open pull request against...
r2541 var other_repos_info = ${c.other_repos_info|n};
white space cleanup
r2907
created pull-request overview
r2395 var loadPreview = function(){
Mads Kiilerich
html: don't use tabs
r3197 YUD.setStyle(YUD.get('pull_request_overview_url').parentElement,'display','none');
be more explicit about constructing compare url
r3321 //url template
Added basic models for saving open pull requests...
r2434 var url = "${h.url('compare_url',
Mads Kiilerich
compare: swap org and other when they refer to different repos, ie are pull request style...
r3322 repo_name='__other_repo__',
org_ref_type='__other_ref_type__',
org_ref='__other_ref__',
other_repo='__org_repo__',
other_ref_type='__org_ref_type__',
other_ref='__org_ref__',
Mads Kiilerich
compare and diff: remove unused "bundle" functionality...
r3304 as_form=True,
Mads Kiilerich
compare/pullrequest: introduce merge parameter...
r3486 merge=True,
Mads Kiilerich
compare: drop unused rev_start and rev_end
r3484 )}";
be more explicit about constructing compare url
r3321 var org_repo = YUQ('#pull_request_form #org_repo')[0].value;
var org_ref = YUQ('#pull_request_form #org_ref')[0].value.split(':');
whitespace cleanup
r3338
be more explicit about constructing compare url
r3321 var other_repo = YUQ('#pull_request_form #other_repo')[0].value;
var other_ref = YUQ('#pull_request_form #other_ref')[0].value.split(':');
whitespace cleanup
r3338
created pull-request overview
r2395 var select_refs = YUQ('#pull_request_form select.refs')
be more explicit about constructing compare url
r3321 var rev_data = {
Mads Kiilerich
pullrequests: use stable revisions in compare urls instead of bookmark/branch/tag
r3441 'org_repo': org_repo,
'org_ref': org_ref[2],
'org_ref_type': 'rev',
'other_repo': other_repo,
'other_ref': other_ref[2],
'other_ref_type': 'rev',
be more explicit about constructing compare url
r3321 }; // gather the org/other ref and repo here
whitespace cleanup
r3338
be more explicit about constructing compare url
r3321 for (k in rev_data){
codecleaner, fix tabs -> spaces
r3449 url = url.replace('__'+k+'__',rev_data[k]);
created pull-request overview
r2395 }
Added basic models for saving open pull requests...
r2434
Mads Kiilerich
pullrequest: show 'loading' while waiting for compare_url to load
r3438 YUD.get('pull_request_overview').innerHTML = "${_('Loading ...')}";
Mads Kiilerich
pullrequest: show 'details' link immediately - don't wait for changeset list
r3439 YUD.get('pull_request_overview_url').href = url; // shouldn't have as_form ... but ...
YUD.setStyle(YUD.get('pull_request_overview_url').parentElement,'display','');
added link for detailed overview in pull-request form
r2396 ypjax(url,'pull_request_overview', function(data){
Mads Kiilerich
html: don't use tabs
r3197 var sel_box = YUQ('#pull_request_form #other_repo')[0];
var repo_name = sel_box.options[sel_box.selectedIndex].value;
Mads Kiilerich
pullrequest: just replace children of other_ref when other_repo changes...
r3512 YUD.get('other_repo_desc').innerHTML = other_repos_info[repo_name]['description'];
// replace options of other_ref with the ones for the current other_repo
var other_ref_selector = YUD.get('other_ref');
var new_select = YUD.createElementFromMarkup(other_repos_info[repo_name]['revs']);
var new_selectedIndex = new_select.selectedIndex;
other_ref_selector.innerHTML = ""; // clear old options
while (new_select.length > 0){ // children will be popped when appened to other_ref_selector
other_ref_selector.appendChild(new_select.children[0]);
}
// browsers lost track of selected when appendChild was used
other_ref_selector.selectedIndex = new_selectedIndex;
// reset && add the reviewer based on selected repo
review members are dynamically changed based on selected other_repo owner...
r3388 var _data = other_repos_info[repo_name];
YUD.get('review_members').innerHTML = '';
addReviewMember(_data.user.user_id, _data.user.firstname,
codecleaner, fix tabs -> spaces
r3449 _data.user.lastname, _data.user.username,
_data.user.gravatar_link);
Added basic models for saving open pull requests...
r2434 })
created pull-request overview
r2395 }
Mads Kiilerich
pull request: only bind action to other_repo change once
r3325
Mads Kiilerich
pull request: update changeset list automatically - remove refresh icon...
r3326 ## refresh automatically when something changes (org_repo can't change)
YUE.on('org_ref', 'change', function(e){
loadPreview();
});
Mads Kiilerich
pull request: only bind action to other_repo change once
r3325 YUE.on('other_repo', 'change', function(e){
var repo_name = e.currentTarget.value;
Mads Kiilerich
pull request: update changeset list automatically - remove refresh icon...
r3326 loadPreview();
Mads Kiilerich
pull request: only bind action to other_repo change once
r3325 });
Mads Kiilerich
pull request: update changeset list automatically - remove refresh icon...
r3326 YUE.on('other_ref', 'change', function(e){
loadPreview();
});
Added basic models for saving open pull requests...
r2434
//lazy load overview after 0.5s
setTimeout(loadPreview, 500)
created pull-request overview
r2395 </script>
pull requests draft UI
r2244 </%def>