diff --git a/rhodecode/lib/celerypylons/commands.py b/rhodecode/lib/celerypylons/commands.py --- a/rhodecode/lib/celerypylons/commands.py +++ b/rhodecode/lib/celerypylons/commands.py @@ -35,7 +35,7 @@ class CeleryCommand(BasePasterCommand): except KeyError: CELERY_ON = False - if CELERY_ON == False: + if not CELERY_ON: raise Exception('Please enable celery_on in .ini config ' 'file before running celeryd') rhodecode.CELERY_ON = CELERY_ON diff --git a/rhodecode/lib/dbmigrate/migrate/versioning/version.py b/rhodecode/lib/dbmigrate/migrate/versioning/version.py --- a/rhodecode/lib/dbmigrate/migrate/versioning/version.py +++ b/rhodecode/lib/dbmigrate/migrate/versioning/version.py @@ -90,7 +90,7 @@ class Collection(pathed.Pathed): return max([VerNum(0)] + self.versions.keys()) def _next_ver_num(self, use_timestamp_numbering): - if use_timestamp_numbering == True: + if use_timestamp_numbering: return VerNum(int(datetime.utcnow().strftime('%Y%m%d%H%M%S'))) else: return self.latest + 1 diff --git a/rhodecode/lib/utils.py b/rhodecode/lib/utils.py --- a/rhodecode/lib/utils.py +++ b/rhodecode/lib/utils.py @@ -555,7 +555,7 @@ def load_rcextensions(root_path): #OVERRIDE OUR EXTENSIONS FROM RC-EXTENSIONS (if present) - if getattr(EXT, 'INDEX_EXTENSIONS', []) != []: + if getattr(EXT, 'INDEX_EXTENSIONS', []): log.debug('settings custom INDEX_EXTENSIONS') conf.INDEX_EXTENSIONS = getattr(EXT, 'INDEX_EXTENSIONS', []) diff --git a/rhodecode/model/permission.py b/rhodecode/model/permission.py --- a/rhodecode/model/permission.py +++ b/rhodecode/model/permission.py @@ -123,7 +123,7 @@ class PermissionModel(BaseModel): self.sa.add(p) #stage 3 update all default permissions for repos if checked - if form_result['overwrite_default_repo'] == True: + if form_result['overwrite_default_repo']: _def_name = form_result['default_repo_perm'].split('repository.')[-1] _def = Permission.get_by_key('repository.' + _def_name) # repos @@ -136,7 +136,7 @@ class PermissionModel(BaseModel): r2p.permission = _def self.sa.add(r2p) - if form_result['overwrite_default_group'] == True: + if form_result['overwrite_default_group']: _def_name = form_result['default_group_perm'].split('group.')[-1] # groups _def = Permission.get_by_key('group.' + _def_name) @@ -146,7 +146,7 @@ class PermissionModel(BaseModel): g2p.permission = _def self.sa.add(g2p) - if form_result['overwrite_default_user_group'] == True: + if form_result['overwrite_default_user_group']: _def_name = form_result['default_user_group_perm'].split('usergroup.')[-1] # groups _def = Permission.get_by_key('usergroup.' + _def_name)