diff --git a/kallithea/controllers/admin/my_account.py b/kallithea/controllers/admin/my_account.py --- a/kallithea/controllers/admin/my_account.py +++ b/kallithea/controllers/admin/my_account.py @@ -42,8 +42,7 @@ from kallithea.lib.auth import LoginRequ from kallithea.lib.base import BaseController, render from kallithea.lib.utils2 import generate_api_key, safe_int from kallithea.lib.compat import json -from kallithea.model.db import Repository, \ - UserEmailMap, UserApiKeys, User, UserFollowing +from kallithea.model.db import Repository, UserEmailMap, User, UserFollowing from kallithea.model.forms import UserForm, PasswordChangeForm from kallithea.model.user import UserModel from kallithea.model.repo import RepoModel diff --git a/kallithea/controllers/admin/permissions.py b/kallithea/controllers/admin/permissions.py --- a/kallithea/controllers/admin/permissions.py +++ b/kallithea/controllers/admin/permissions.py @@ -36,8 +36,7 @@ from pylons.controllers.util import redi from pylons.i18n.translation import _ from kallithea.lib import helpers as h -from kallithea.lib.auth import LoginRequired, HasPermissionAllDecorator,\ - AuthUser +from kallithea.lib.auth import LoginRequired, HasPermissionAllDecorator from kallithea.lib.base import BaseController, render from kallithea.model.forms import DefaultPermissionsForm from kallithea.model.permission import PermissionModel diff --git a/kallithea/controllers/admin/repo_groups.py b/kallithea/controllers/admin/repo_groups.py --- a/kallithea/controllers/admin/repo_groups.py +++ b/kallithea/controllers/admin/repo_groups.py @@ -39,8 +39,8 @@ from pylons.i18n.translation import _, u import kallithea from kallithea.lib import helpers as h from kallithea.lib.compat import json -from kallithea.lib.auth import LoginRequired, HasPermissionAnyDecorator,\ - HasRepoGroupPermissionAnyDecorator, HasRepoGroupPermissionAll,\ +from kallithea.lib.auth import LoginRequired, \ + HasRepoGroupPermissionAnyDecorator, HasRepoGroupPermissionAll, \ HasPermissionAll from kallithea.lib.base import BaseController, render from kallithea.model.db import RepoGroup, Repository diff --git a/kallithea/controllers/admin/repos.py b/kallithea/controllers/admin/repos.py --- a/kallithea/controllers/admin/repos.py +++ b/kallithea/controllers/admin/repos.py @@ -36,11 +36,11 @@ from pylons.i18n.translation import _ from sqlalchemy.sql.expression import func from kallithea.lib import helpers as h -from kallithea.lib.auth import LoginRequired, HasPermissionAllDecorator, \ - HasRepoPermissionAllDecorator, NotAnonymous, HasPermissionAny, HasPermissionAll, \ - HasRepoGroupPermissionAny, HasRepoPermissionAnyDecorator +from kallithea.lib.auth import LoginRequired, \ + HasRepoPermissionAllDecorator, NotAnonymous, HasPermissionAny, \ + HasRepoPermissionAnyDecorator from kallithea.lib.base import BaseRepoController, render -from kallithea.lib.utils import action_logger, repo_name_slug, jsonify +from kallithea.lib.utils import action_logger, jsonify from kallithea.lib.vcs import RepositoryError from kallithea.model.meta import Session from kallithea.model.db import User, Repository, UserFollowing, RepoGroup,\ diff --git a/kallithea/controllers/admin/user_groups.py b/kallithea/controllers/admin/user_groups.py --- a/kallithea/controllers/admin/user_groups.py +++ b/kallithea/controllers/admin/user_groups.py @@ -40,18 +40,18 @@ from webob.exc import HTTPInternalServer import kallithea from kallithea.lib import helpers as h -from kallithea.lib.exceptions import UserGroupsAssignedException,\ +from kallithea.lib.exceptions import UserGroupsAssignedException, \ RepoGroupAssignmentError from kallithea.lib.utils2 import safe_unicode, safe_int -from kallithea.lib.auth import LoginRequired, HasPermissionAllDecorator,\ +from kallithea.lib.auth import LoginRequired, \ HasUserGroupPermissionAnyDecorator, HasPermissionAnyDecorator from kallithea.lib.base import BaseController, render from kallithea.model.scm import UserGroupList from kallithea.model.user_group import UserGroupModel from kallithea.model.repo import RepoModel -from kallithea.model.db import User, UserGroup, UserGroupToPerm,\ +from kallithea.model.db import User, UserGroup, UserGroupToPerm, \ UserGroupRepoToPerm, UserGroupRepoGroupToPerm -from kallithea.model.forms import UserGroupForm, UserGroupPermsForm,\ +from kallithea.model.forms import UserGroupForm, UserGroupPermsForm, \ CustomDefaultPermissionsForm from kallithea.model.meta import Session from kallithea.lib.utils import action_logger diff --git a/kallithea/controllers/compare.py b/kallithea/controllers/compare.py --- a/kallithea/controllers/compare.py +++ b/kallithea/controllers/compare.py @@ -42,8 +42,7 @@ from kallithea.lib.auth import LoginRequ from kallithea.lib import diffs from kallithea.model.db import Repository from kallithea.lib.diffs import LimitedDiffContainer -from kallithea.controllers.changeset import _ignorews_url,\ - _context_url, get_line_ctx, get_ignore_ws +from kallithea.controllers.changeset import _ignorews_url, _context_url from kallithea.lib.graphmod import graph_data from kallithea.lib.compat import json diff --git a/kallithea/controllers/forks.py b/kallithea/controllers/forks.py --- a/kallithea/controllers/forks.py +++ b/kallithea/controllers/forks.py @@ -40,8 +40,7 @@ from kallithea.lib.helpers import Page from kallithea.lib.auth import LoginRequired, HasRepoPermissionAnyDecorator, \ NotAnonymous, HasRepoPermissionAny, HasPermissionAnyDecorator, HasPermissionAny from kallithea.lib.base import BaseRepoController, render -from kallithea.model.db import Repository, RepoGroup, UserFollowing, User,\ - Ui +from kallithea.model.db import Repository, UserFollowing, User, Ui from kallithea.model.repo import RepoModel from kallithea.model.forms import RepoForkForm from kallithea.model.scm import ScmModel, AvailableRepoGroupChoices diff --git a/kallithea/controllers/pullrequests.py b/kallithea/controllers/pullrequests.py --- a/kallithea/controllers/pullrequests.py +++ b/kallithea/controllers/pullrequests.py @@ -49,7 +49,7 @@ from kallithea.lib.utils import action_l from kallithea.lib.vcs.utils import safe_str from kallithea.lib.vcs.exceptions import EmptyRepositoryError from kallithea.lib.diffs import LimitedDiffContainer -from kallithea.model.db import PullRequest, ChangesetStatus, ChangesetComment,\ +from kallithea.model.db import PullRequest, ChangesetStatus, ChangesetComment,\ PullRequestReviewers from kallithea.model.pull_request import PullRequestModel from kallithea.model.meta import Session @@ -58,8 +58,7 @@ from kallithea.model.comment import Chan from kallithea.model.changeset_status import ChangesetStatusModel from kallithea.model.forms import PullRequestForm, PullRequestPostForm from kallithea.lib.utils2 import safe_int -from kallithea.controllers.changeset import _ignorews_url,\ - _context_url, get_line_ctx, get_ignore_ws +from kallithea.controllers.changeset import _ignorews_url, _context_url from kallithea.controllers.compare import CompareController from kallithea.lib.graphmod import graph_data diff --git a/kallithea/lib/db_manage.py b/kallithea/lib/db_manage.py --- a/kallithea/lib/db_manage.py +++ b/kallithea/lib/db_manage.py @@ -39,7 +39,7 @@ from kallithea.lib.utils import ask_ok from kallithea.model import init_model from kallithea.model.db import User, Permission, Ui, \ Setting, UserToPerm, DbMigrateVersion, RepoGroup, \ - UserRepoGroupToPerm, CacheInvalidation, UserGroup, Repository + UserRepoGroupToPerm, CacheInvalidation, Repository from sqlalchemy.engine import create_engine from kallithea.model.repo_group import RepoGroupModel diff --git a/kallithea/lib/dbmigrate/schema/db_1_6_0.py b/kallithea/lib/dbmigrate/schema/db_1_6_0.py --- a/kallithea/lib/dbmigrate/schema/db_1_6_0.py +++ b/kallithea/lib/dbmigrate/schema/db_1_6_0.py @@ -48,7 +48,7 @@ from kallithea.lib.vcs.utils.lazy import from kallithea.lib.vcs.backends.base import EmptyChangeset from kallithea.lib.utils2 import str2bool, safe_str, get_changeset_safe, \ - safe_unicode, remove_suffix, remove_prefix, time_to_datetime, _set_extras + safe_unicode, remove_suffix, remove_prefix, time_to_datetime from kallithea.lib.compat import json from kallithea.lib.caching_query import FromCache diff --git a/kallithea/lib/dbmigrate/schema/db_1_7_0.py b/kallithea/lib/dbmigrate/schema/db_1_7_0.py --- a/kallithea/lib/dbmigrate/schema/db_1_7_0.py +++ b/kallithea/lib/dbmigrate/schema/db_1_7_0.py @@ -48,7 +48,7 @@ from kallithea.lib.vcs.utils.lazy import from kallithea.lib.vcs.backends.base import EmptyChangeset from kallithea.lib.utils2 import str2bool, safe_str, get_changeset_safe, \ - safe_unicode, remove_suffix, remove_prefix, time_to_datetime, _set_extras + safe_unicode, remove_prefix, time_to_datetime from kallithea.lib.compat import json from kallithea.lib.caching_query import FromCache diff --git a/kallithea/lib/dbmigrate/schema/db_1_8_0.py b/kallithea/lib/dbmigrate/schema/db_1_8_0.py --- a/kallithea/lib/dbmigrate/schema/db_1_8_0.py +++ b/kallithea/lib/dbmigrate/schema/db_1_8_0.py @@ -48,7 +48,7 @@ from kallithea.lib.vcs.utils.lazy import from kallithea.lib.vcs.backends.base import EmptyChangeset from kallithea.lib.utils2 import str2bool, safe_str, get_changeset_safe, \ - safe_unicode, remove_suffix, remove_prefix, time_to_datetime, _set_extras + safe_unicode, remove_prefix, time_to_datetime from kallithea.lib.compat import json from kallithea.lib.caching_query import FromCache diff --git a/kallithea/lib/dbmigrate/versions/004_version_1_3_0.py b/kallithea/lib/dbmigrate/versions/004_version_1_3_0.py --- a/kallithea/lib/dbmigrate/versions/004_version_1_3_0.py +++ b/kallithea/lib/dbmigrate/versions/004_version_1_3_0.py @@ -22,19 +22,19 @@ def upgrade(migrate_engine): #========================================================================== # Add table `changeset_comments` #========================================================================== - from kallithea.lib.dbmigrate.schema.db_1_3_0 import ChangesetComment + from kallithea.lib.dbmigrate.schema.db_1_3_0 import ChangesetComment ChangesetComment().__table__.create() #========================================================================== # Add table `notifications` #========================================================================== - from kallithea.lib.dbmigrate.schema.db_1_3_0 import Notification + from kallithea.lib.dbmigrate.schema.db_1_3_0 import Notification Notification().__table__.create() #========================================================================== # Add table `user_to_notification` #========================================================================== - from kallithea.lib.dbmigrate.schema.db_1_3_0 import UserNotification + from kallithea.lib.dbmigrate.schema.db_1_3_0 import UserNotification UserNotification().__table__.create() #========================================================================== diff --git a/kallithea/lib/utils.py b/kallithea/lib/utils.py --- a/kallithea/lib/utils.py +++ b/kallithea/lib/utils.py @@ -50,11 +50,9 @@ from kallithea.lib.vcs.utils.hgcompat im from kallithea.lib.vcs.utils.helpers import get_scm from kallithea.lib.vcs.exceptions import VCSError -from kallithea.lib.caching_query import FromCache - from kallithea.model import meta from kallithea.model.db import Repository, User, Ui, \ - UserLog, RepoGroup, Setting, CacheInvalidation, UserGroup + UserLog, RepoGroup, Setting, UserGroup from kallithea.model.meta import Session from kallithea.model.repo_group import RepoGroupModel from kallithea.lib.utils2 import safe_str, safe_unicode, get_current_authuser @@ -407,7 +405,6 @@ def set_vcs_config(config): :param config: kallithea.CONFIG """ - import kallithea from kallithea.lib.vcs import conf from kallithea.lib.utils2 import aslist conf.settings.BACKENDS = { diff --git a/kallithea/lib/vcs/backends/git/changeset.py b/kallithea/lib/vcs/backends/git/changeset.py --- a/kallithea/lib/vcs/backends/git/changeset.py +++ b/kallithea/lib/vcs/backends/git/changeset.py @@ -10,7 +10,7 @@ from kallithea.lib.vcs.exceptions import ChangesetDoesNotExistError, ImproperArchiveTypeError ) from kallithea.lib.vcs.nodes import ( - FileNode, DirNode, NodeKind, RootNode, RemovedFileNode, SubModuleNode, + FileNode, DirNode, NodeKind, RootNode, SubModuleNode, ChangedFileNodesGenerator, AddedFileNodesGenerator, RemovedFileNodesGenerator ) from kallithea.lib.vcs.utils import ( diff --git a/kallithea/lib/vcs/backends/git/repository.py b/kallithea/lib/vcs/backends/git/repository.py --- a/kallithea/lib/vcs/backends/git/repository.py +++ b/kallithea/lib/vcs/backends/git/repository.py @@ -17,7 +17,6 @@ import urllib import urllib2 import logging import posixpath -import string from dulwich.objects import Tag from dulwich.repo import Repo, NotGitRepository diff --git a/kallithea/lib/vcs/backends/hg/repository.py b/kallithea/lib/vcs/backends/hg/repository.py --- a/kallithea/lib/vcs/backends/hg/repository.py +++ b/kallithea/lib/vcs/backends/hg/repository.py @@ -29,7 +29,7 @@ from kallithea.lib.vcs.utils.lazy import from kallithea.lib.vcs.utils.ordered_dict import OrderedDict from kallithea.lib.vcs.utils.paths import abspath from kallithea.lib.vcs.utils.hgcompat import ( - ui, nullid, match, patch, diffopts, clone, get_contact, pull, + ui, nullid, match, patch, diffopts, clone, get_contact, localrepository, RepoLookupError, Abort, RepoError, hex, scmutil, hg_url, httpbasicauthhandler, httpdigestauthhandler, peer, httppeer, sshpeer ) diff --git a/kallithea/model/changeset_status.py b/kallithea/model/changeset_status.py --- a/kallithea/model/changeset_status.py +++ b/kallithea/model/changeset_status.py @@ -26,7 +26,6 @@ Original author and date, and relevant c """ import logging -from collections import defaultdict from sqlalchemy.orm import joinedload from kallithea.model import BaseModel diff --git a/kallithea/model/db.py b/kallithea/model/db.py --- a/kallithea/model/db.py +++ b/kallithea/model/db.py @@ -46,7 +46,6 @@ from kallithea import DB_PREFIX from kallithea.lib.exceptions import DefaultUserException from kallithea.lib.vcs import get_backend from kallithea.lib.vcs.utils.helpers import get_scm -from kallithea.lib.vcs.exceptions import VCSError from kallithea.lib.vcs.utils.lazy import LazyProperty from kallithea.lib.vcs.backends.base import EmptyChangeset diff --git a/kallithea/model/gist.py b/kallithea/model/gist.py --- a/kallithea/model/gist.py +++ b/kallithea/model/gist.py @@ -33,7 +33,7 @@ import traceback import shutil from kallithea.lib.utils2 import safe_unicode, unique_id, safe_int, \ - time_to_datetime, safe_str, AttributeDict + time_to_datetime, AttributeDict from kallithea.lib.compat import json from kallithea.model import BaseModel from kallithea.model.db import Gist diff --git a/kallithea/model/repo.py b/kallithea/model/repo.py --- a/kallithea/model/repo.py +++ b/kallithea/model/repo.py @@ -45,8 +45,7 @@ from kallithea.lib.hooks import log_dele from kallithea.model import BaseModel from kallithea.model.db import Repository, UserRepoToPerm, UserGroupRepoToPerm, \ UserRepoGroupToPerm, UserGroupRepoGroupToPerm, User, Permission, \ - Statistics, UserGroup, UserGroupMember, Ui, RepoGroup, \ - Setting, RepositoryField + Statistics, UserGroup, Ui, RepoGroup, RepositoryField from kallithea.lib import helpers as h from kallithea.lib.auth import HasRepoPermissionAny, HasUserGroupPermissionAny diff --git a/kallithea/model/validators.py b/kallithea/model/validators.py --- a/kallithea/model/validators.py +++ b/kallithea/model/validators.py @@ -31,9 +31,8 @@ from formencode.validators import ( from kallithea.lib.compat import OrderedSet from kallithea.lib import ipaddr from kallithea.lib.utils import repo_name_slug -from kallithea.lib.utils2 import safe_int, str2bool, aslist -from kallithea.model.db import RepoGroup, Repository, UserGroup, User,\ - ChangesetStatus +from kallithea.lib.utils2 import str2bool, aslist +from kallithea.model.db import RepoGroup, Repository, UserGroup, User from kallithea.lib.exceptions import LdapImportError from kallithea.config.routing import ADMIN_PREFIX from kallithea.lib.auth import HasRepoGroupPermissionAny, HasPermissionAny diff --git a/kallithea/tests/functional/test_admin_notifications.py b/kallithea/tests/functional/test_admin_notifications.py --- a/kallithea/tests/functional/test_admin_notifications.py +++ b/kallithea/tests/functional/test_admin_notifications.py @@ -1,5 +1,5 @@ from kallithea.tests import * -from kallithea.model.db import Notification, User +from kallithea.model.db import User from kallithea.model.user import UserModel from kallithea.model.notification import NotificationModel diff --git a/kallithea/tests/functional/test_admin_users.py b/kallithea/tests/functional/test_admin_users.py --- a/kallithea/tests/functional/test_admin_users.py +++ b/kallithea/tests/functional/test_admin_users.py @@ -13,7 +13,6 @@ # along with this program. If not, see . from sqlalchemy.orm.exc import NoResultFound -from webob.exc import HTTPNotFound from kallithea.tests import * from kallithea.tests.fixture import Fixture diff --git a/kallithea/tests/functional/test_compare.py b/kallithea/tests/functional/test_compare.py --- a/kallithea/tests/functional/test_compare.py +++ b/kallithea/tests/functional/test_compare.py @@ -2,7 +2,6 @@ from kallithea.tests import * from kallithea.model.repo import RepoModel from kallithea.model.meta import Session -from kallithea.model.db import Repository from kallithea.tests.fixture import Fixture fixture = Fixture() diff --git a/kallithea/tests/functional/test_pullrequests.py b/kallithea/tests/functional/test_pullrequests.py --- a/kallithea/tests/functional/test_pullrequests.py +++ b/kallithea/tests/functional/test_pullrequests.py @@ -5,7 +5,6 @@ from kallithea.tests.fixture import Fixt from kallithea.model.meta import Session from kallithea.controllers.pullrequests import PullrequestsController -from kallithea.lib.exceptions import UserInvalidException fixture = Fixture() diff --git a/kallithea/tests/other/test_mail.py b/kallithea/tests/other/test_mail.py --- a/kallithea/tests/other/test_mail.py +++ b/kallithea/tests/other/test_mail.py @@ -2,7 +2,6 @@ import mock import kallithea from kallithea.tests import * -from kallithea.model.db import User class smtplib_mock(object): diff --git a/kallithea/tests/other/test_validators.py b/kallithea/tests/other/test_validators.py --- a/kallithea/tests/other/test_validators.py +++ b/kallithea/tests/other/test_validators.py @@ -8,8 +8,6 @@ from kallithea.model.user_group import U from kallithea.model.meta import Session from kallithea.model.repo_group import RepoGroupModel -from kallithea.model.db import ChangesetStatus, ChangesetComment, Repository -from kallithea.model.changeset_status import ChangesetStatusModel from kallithea.tests.fixture import Fixture fixture = Fixture()