# HG changeset patch # User Thomas De Schampheleire # Date 2017-03-15 20:00:40 # Node ID 2f9313074853fe40e6f1c7d917dbee3e9b4695bf # Parent a9e776515d8d7b0bcdd86b52cc26f797d25a313e controllers: remove empty __before__ methods __before__ methods that only call the super __before__ method are redundant and can be removed. The super's method will be called directly. diff --git a/kallithea/controllers/followers.py b/kallithea/controllers/followers.py --- a/kallithea/controllers/followers.py +++ b/kallithea/controllers/followers.py @@ -40,9 +40,6 @@ log = logging.getLogger(__name__) class FollowersController(BaseRepoController): - def __before__(self): - super(FollowersController, self).__before__() - @LoginRequired() @HasRepoPermissionLevelDecorator('read') def followers(self, repo_name): diff --git a/kallithea/controllers/forks.py b/kallithea/controllers/forks.py --- a/kallithea/controllers/forks.py +++ b/kallithea/controllers/forks.py @@ -52,9 +52,6 @@ log = logging.getLogger(__name__) class ForksController(BaseRepoController): - def __before__(self): - super(ForksController, self).__before__() - def __load_defaults(self): if HasPermissionAny('hg.create.write_on_repogroup.true')(): repo_group_perm_level = 'write' diff --git a/kallithea/controllers/home.py b/kallithea/controllers/home.py --- a/kallithea/controllers/home.py +++ b/kallithea/controllers/home.py @@ -45,9 +45,6 @@ log = logging.getLogger(__name__) class HomeController(BaseController): - def __before__(self): - super(HomeController, self).__before__() - def about(self): return render('/about.html') diff --git a/kallithea/controllers/login.py b/kallithea/controllers/login.py --- a/kallithea/controllers/login.py +++ b/kallithea/controllers/login.py @@ -53,9 +53,6 @@ log = logging.getLogger(__name__) class LoginController(BaseController): - def __before__(self): - super(LoginController, self).__before__() - def _validate_came_from(self, came_from, _re=re.compile(r"/(?!/)[-!#$%&'()*+,./:;=?@_~0-9A-Za-z]*$")): """Return True if came_from is valid and can and should be used. diff --git a/kallithea/controllers/search.py b/kallithea/controllers/search.py --- a/kallithea/controllers/search.py +++ b/kallithea/controllers/search.py @@ -49,9 +49,6 @@ log = logging.getLogger(__name__) class SearchController(BaseRepoController): - def __before__(self): - super(SearchController, self).__before__() - @LoginRequired() def index(self, repo_name=None): c.repo_name = repo_name diff --git a/kallithea/controllers/summary.py b/kallithea/controllers/summary.py --- a/kallithea/controllers/summary.py +++ b/kallithea/controllers/summary.py @@ -62,9 +62,6 @@ README_FILES = [''.join([x[0][0], x[1][0 class SummaryController(BaseRepoController): - def __before__(self): - super(SummaryController, self).__before__() - def __get_readme_data(self, db_repo): repo_name = db_repo.repo_name log.debug('Looking for README file')