# HG changeset patch # User Marcin Kuzminski # Date 2012-09-02 21:29:07 # Node ID a93c07ade43a42af9f09fb0705965f164c0be40f # Parent d03d51b6541e8b2d75dd4c34fc2a2767311ce6b4 Added huge diff protection for RSS/ATOM feeds. It can really be a performance killer for huge diffs. diff --git a/rhodecode/controllers/feed.py b/rhodecode/controllers/feed.py --- a/rhodecode/controllers/feed.py +++ b/rhodecode/controllers/feed.py @@ -59,8 +59,14 @@ class FeedController(BaseRepoController) def __changes(self, cs): changes = [] - - diffprocessor = DiffProcessor(cs.diff()) + _diff = cs.diff() + # we need to protect from parsing huge diffs here other way + # we can kill the server, 32*1024 chars is a reasonable limit + HUGE_DIFF = 32 * 1024 + if len(_diff) > HUGE_DIFF: + changes = ['\n ' + _('Changeset was too big and was cut off...')] + return changes + diffprocessor = DiffProcessor(_diff) stats = diffprocessor.prepare(inline_diff=False) for st in stats: st.update({'added': st['stats'][0],