# HG changeset patch # User Manuel Jacob # Date 2023-03-29 09:05:00 # Node ID ea1a656702ab481e45f6651f0b5f914cdc716c89 # Parent 86b9eed9d105293dbd46a4d1ec07e5d0c240bb36 api: fix get_changeset() when incomplete raw_id is passed with with_reviews Previously, ChangesetStatusModel was queried with the raw_id passed as an argument to the API function. When the raw_id was incomplete (i.e. shortened), no reviews were found. Using the full raw_id from the changeset instance fixes that. Someone might argue that the caller is supposed to pass a full raw_id to the API function. However, in any case, the return value should not be incomplete without notice. diff --git a/kallithea/controllers/api/api.py b/kallithea/controllers/api/api.py --- a/kallithea/controllers/api/api.py +++ b/kallithea/controllers/api/api.py @@ -1862,7 +1862,7 @@ class ApiController(JSONRPCController): if with_reviews: reviews = ChangesetStatusModel().get_statuses( - repo.repo_name, raw_id) + repo.repo_name, changeset.raw_id) info["reviews"] = reviews return info