# HG changeset patch
# User Marcin Kuzminski <marcin@python-works.com>
# Date 2012-02-24 18:53:11
# Node ID ef3114b01c7c4242ef7d6596dd247d2bc13b2a6f
# Parent  88d5e42a66c37bf88d64353411d2f099d52f5c80

fixed issues when urlify commit created empty links when link_ param was empty

diff --git a/rhodecode/lib/helpers.py b/rhodecode/lib/helpers.py
--- a/rhodecode/lib/helpers.py
+++ b/rhodecode/lib/helpers.py
@@ -827,6 +827,15 @@ def urlify_changesets(text_, repository)
 
 
 def urlify_commit(text_, repository=None, link_=None):
+    """
+    Parses given text message and makes proper links.
+    issues are linked to given issue-server, and rest is a changeset link
+    if link_ is given, in other case it's a plain text
+
+    :param text_:
+    :param repository:
+    :param link_: changeset link
+    """
     import re
     import traceback
 
@@ -878,8 +887,9 @@ def urlify_commit(text_, repository=None
 
             newtext = URL_PAT.sub(url_func, text_)
 
-            # wrap not links into final link => link_
-            newtext = linkify_others(newtext, link_)
+            if link_:
+                # wrap not links into final link => link_
+                newtext = linkify_others(newtext, link_)
 
             return literal(newtext)
     except: