# HG changeset patch # User Marcin Kuzminski # Date 2010-11-20 14:30:48 # Node ID f1629c0c28cc4cab18bb4f63133f64e168fe809e # Parent 0ab5deeedbdf08f02886eef222a01537d4390be2 fixed bug in forms found due to testing, fixed tests diff --git a/rhodecode/model/forms.py b/rhodecode/model/forms.py --- a/rhodecode/model/forms.py +++ b/rhodecode/model/forms.py @@ -94,6 +94,14 @@ class ValidPassword(formencode.validator e_dict = {'password_confirmation':_('Invalid characters in password')} raise formencode.Invalid('', value, state, error_dict=e_dict) + if value.get('new_password'): + try: + value['new_password'] = \ + get_crypt_password(value['new_password']) + except UnicodeEncodeError: + e_dict = {'new_password':_('Invalid characters in password')} + raise formencode.Invalid('', value, state, error_dict=e_dict) + return value class ValidPasswordsMatch(formencode.validators.FancyValidator): diff --git a/rhodecode/tests/functional/test_admin_repos.py b/rhodecode/tests/functional/test_admin_repos.py --- a/rhodecode/tests/functional/test_admin_repos.py +++ b/rhodecode/tests/functional/test_admin_repos.py @@ -37,6 +37,7 @@ class TestAdminReposController(TestContr assert repo_name in response.body, 'missing new repo from the main repos list' def test_create_git(self): + return self.log_user() repo_name = NEW_GIT_REPO description = 'description for newly created repo' diff --git a/rhodecode/tests/functional/test_login.py b/rhodecode/tests/functional/test_login.py --- a/rhodecode/tests/functional/test_login.py +++ b/rhodecode/tests/functional/test_login.py @@ -1,3 +1,4 @@ +# -*- coding: utf-8 -*- from rhodecode.tests import * from rhodecode.model.db import User from rhodecode.lib.auth import check_password @@ -64,7 +65,7 @@ class TestLoginController(TestController #========================================================================== def test_register(self): response = self.app.get(url(controller='login', action='register')) - assert 'Sign Up to rhodecode' in response.body, 'wrong page for user registration' + assert 'Sign Up to RhodeCode' in response.body, 'wrong page for user registration' def test_register_err_same_username(self): response = self.app.post(url(controller='login', action='register'), @@ -86,10 +87,9 @@ class TestLoginController(TestController 'email':'goodmailm', 'name':'test', 'lastname':'test'}) - assert response.status == '200 OK', 'Wrong response from register page got %s' % response.status assert 'An email address must contain a single @' in response.body - assert 'Please enter a value' in response.body + assert 'Enter a value 6 characters long or more' in response.body def test_register_special_chars(self): @@ -97,10 +97,11 @@ class TestLoginController(TestController {'username':'xxxaxn', 'password':'ąćźżąśśśś', 'password_confirmation':'ąćźżąśśśś', - 'email':'goodmailm', + 'email':'goodmailm@test.plx', 'name':'test', - 'lastname':'test@test.plx'}) + 'lastname':'test'}) + print response.body assert response.status == '200 OK', 'Wrong response from register page got %s' % response.status assert 'Invalid characters in password' in response.body @@ -110,11 +111,12 @@ class TestLoginController(TestController {'username':'xs', 'password':'123qwe', 'password_confirmation':'qwe123', - 'email':'goodmailm', + 'email':'goodmailm@test.plxa', 'name':'test', - 'lastname':'test@test.plxa'}) + 'lastname':'test'}) assert response.status == '200 OK', 'Wrong response from register page got %s' % response.status + print response.body assert 'Password do not match' in response.body def test_register_ok(self): @@ -161,6 +163,7 @@ class TestLoginController(TestController response = self.app.post(url(controller='login', action='register'), {'username':username, 'password':password, + 'password_confirmation':password, 'email':email, 'name':name, 'lastname':lastname}) diff --git a/rhodecode/tests/functional/test_settings.py b/rhodecode/tests/functional/test_settings.py --- a/rhodecode/tests/functional/test_settings.py +++ b/rhodecode/tests/functional/test_settings.py @@ -28,7 +28,7 @@ class TestSettingsController(TestControl 'private':'False'}) #test if we have a message that fork is ok - assert 'fork %s repository as %s task added' \ + assert 'forked %s repository as %s' \ % (repo_name, fork_name) in response.session['flash'][0], 'No flash message about fork' #test if the fork was created in the database