fixes #173, many thanks for slestak for contributing into this one.

CONTRIBUTORS

@@ -6,4 +6,5 b' List of contributors to RhodeCode projec'
     cejones
     Lorenzo M. Catucci <[e-mail]>
     Dmitri Kuznetsov
-    Jared Bunting <[e-mail]>
  No newline at end of file
+    Jared Bunting <[e-mail]>
+    Steve Romanow <[e-mail]>
  No newline at end of file

rhodecode/lib/auth.py

@@ -41,7 +41,7 b' if __platform__ in PLATFORM_WIN:'
 if __platform__ in PLATFORM_OTHERS:
     import bcrypt
 
-from rhodecode.lib import str2bool
+from rhodecode.lib import str2bool, safe_unicode
 from rhodecode.lib.exceptions import LdapPasswordError, LdapUsernameError
 from rhodecode.lib.utils import get_repo_slug
 from rhodecode.lib.auth_ldap import AuthLdap
@@ -207,8 +207,8 b' def authenticate(username, password):'
                                                            .get(k), [''])[0]
 
                 user_attrs = {
-                    'name': get_ldap_attr('ldap_attr_firstname'),
-                    'lastname': get_ldap_attr('ldap_attr_lastname'),
+                 'name': safe_unicode(get_ldap_attr('ldap_attr_firstname')),
+                 'lastname': safe_unicode(get_ldap_attr('ldap_attr_lastname')),
                     'email': get_ldap_attr('ldap_attr_email'),
                     }
 

rhodecode/tests/functional/test_admin_ldap_settings.py

@@ -1,4 +1,11 b''
 from rhodecode.tests import *
+from rhodecode.model.db import RhodeCodeSettings
+
+try:
+    import ldap
+except ImportError:
+    # means that python-ldap is not installed
+    pass
 
 class TestLdapSettingsController(TestController):
 
@@ -6,13 +13,60 b' class TestLdapSettingsController(TestCon'
         self.log_user()
         response = self.app.get(url(controller='admin/ldap_settings',
                                     action='index'))
-        # Test response...
+        self.assertTrue('LDAP administration' in response.body)
 
     def test_ldap_save_settings(self):
-        pass
+        self.log_user()
+        test_url = url(controller='admin/ldap_settings',
+                       action='ldap_settings')
+
+        response = self.app.post(url=test_url,
+            params={'ldap_host' : u'dc.example.com',
+                    'ldap_port' : '999',
+                    'ldap_tls_kind' : 'PLAIN',
+                    'ldap_tls_reqcert' : 'NEVER',
+                    'ldap_dn_user':'test_user',
+                    'ldap_dn_pass':'test_pass',
+                    'ldap_base_dn':'test_base_dn',
+                    'ldap_filter':'test_filter',
+                    'ldap_search_scope':'BASE',
+                    'ldap_attr_login':'test_attr_login',
+                    'ldap_attr_firstname':'ima',
+                    'ldap_attr_lastname':'tester',
+                    'ldap_attr_email':'[e-mail]' })
+
+        new_settings = RhodeCodeSettings.get_ldap_settings()
+        self.assertEqual(new_settings['ldap_host'], u'dc.example.com',
+                         'fail db write compare')
+
+        self.checkSessionFlash(response,
+                               'Ldap settings updated successfully')
 
     def test_ldap_error_form(self):
-        pass
+        self.log_user()
+        test_url = url(controller='admin/ldap_settings',
+                       action='ldap_settings')
+
+        response = self.app.post(url=test_url,
+            params={'ldap_host' : '',
+                    'ldap_port' : 'i-should-be-number',
+                    'ldap_tls_kind' : 'PLAIN',
+                    'ldap_tls_reqcert' : 'NEVER',
+                    'ldap_dn_user':'',
+                    'ldap_dn_pass':'',
+                    'ldap_base_dn':'',
+                    'ldap_filter':'',
+                    'ldap_search_scope':'BASE',
+                    'ldap_attr_login':'', #  <----- missing required input
+                    'ldap_attr_firstname':'',
+                    'ldap_attr_lastname':'',
+                    'ldap_attr_email':'' })
+
+        self.assertTrue("""<span class="error-message">The LDAP Login"""
+                        """ attribute of the CN must be specified""" in
+                        response.body)
+        self.assertTrue("""<span class="error-message">Please """
+                        """enter a number</span>""" in response.body)
 
     def test_ldap_login(self):
         pass