possible fix for #486 undefined variable username

- cleaned a code on git/hg middleware

rhodecode/lib/middleware/simplegit.py

@@ -167,7 +167,6 b' class SimpleGit(BaseVCSController):'
                 #==============================================================
                 # CHECK PERMISSIONS FOR THIS REQUEST USING GIVEN USERNAME
                 #==============================================================
-                if action in ['pull', 'push']:
                     try:
                         user = self.__get_user(username)
                         if user is None or not user.active:
@@ -175,13 +174,13 b' class SimpleGit(BaseVCSController):'
                         username = user.username
                     except:
                         log.error(traceback.format_exc())
-                        return HTTPInternalServerError()(environ,
-                                                         start_response)
+                    return HTTPInternalServerError()(environ, start_response)
 
                     #check permissions for this repository
                     perm = self._check_permission(action, user, repo_name)
                     if perm is not True:
                         return HTTPForbidden()(environ, start_response)
+
         extras = {
             'ip': ipaddr,
             'username': username,

rhodecode/lib/middleware/simplehg.py

@@ -70,7 +70,7 b' class SimpleHg(BaseVCSController):'
             return self.application(environ, start_response)
 
         ipaddr = self._get_ip_addr(environ)
-
+        username = None 
         # skip passing error to error controller
         environ['pylons.status_code_redirect'] = True
 
@@ -131,7 +131,6 b' class SimpleHg(BaseVCSController):'
                 #==============================================================
                 # CHECK PERMISSIONS FOR THIS REQUEST USING GIVEN USERNAME
                 #==============================================================
-                if action in ['pull', 'push']:
                     try:
                         user = self.__get_user(username)
                         if user is None or not user.active:
@@ -139,8 +138,7 b' class SimpleHg(BaseVCSController):'
                         username = user.username
                     except:
                         log.error(traceback.format_exc())
-                        return HTTPInternalServerError()(environ,
-                                                         start_response)
+                    return HTTPInternalServerError()(environ, start_response)
 
                     #check permissions for this repository
                     perm = self._check_permission(action, user, repo_name)