repo group: always update fullpath group_name when changing parent It was usually set anyway before, as the group name usually was specified without being changed and triggered this update.

repo group: drop pointless double handling of parent_group_id updates

tests: introduce test_api_update_repo_group covering update_repo_group api This shows that some of the API is broken. Failing test cases are disabled and will be enabled when the problems are fixed.

repo: introduce enable_downloads and enable_statistics when creating repos These booleans were not shown in the normal repo creation form, so the form validation applied the "default" values of False. These values were however not used by the model when creating repos - it just unconditionally used the real global defaults. The API already exposed some of this, but it wasn't implemented. The web form for creating repos lacked these fields, but it was present in the repo edit form. Just make these fields mandatory. There will thus not be any defaults to apply in the model for creating repos.

templates: align forms for repo creation and repo settings 99% whitespace changes and reordering.

tests: update test_api_create_repo with better coverage of create_repo api Based on test_api_update_repo. This shows that some of the API is broken. Failing test cases are disabled and will be enabled when the problems are fixed.

tests: update_repo without begging the question Don't verify changes by comparing the API result from the update with data directly from the API that contain the same update. Instead, set the expectations based on the previous API data before applying the change.

contributors: update

api docs: make examples use comma more like json does

api docs: more consistent use of space around ":" in examples The examples are informal pseudo code - not json and not python. But let's try to be consistent anyway.

api docs: make examples more like 4 space indented

api docs: drop extra newlines in docstrings

api docs: various minor changes

api docs: update docstrings Changes contributed by toras <toras9000@gmail.com>.

setup: bump Sphinx version Sphinx 3.0.4 doesn't version its dependencies correctly, and it fails with latest jinja 3.1.2: ImportError: cannot import name 'environmentfilter' from 'jinja2' (.../site-packages/jinja2/__init__.py) Latest Sphinx version supports latest Jinja version and seems to render the documentation correctly.

middleware: fix url_scheme_variable 070b8c39736f accidentally introduced a wrong assumption that url_scheme_variable is a bool. Fix to only check whether it has been set to something non-empty.

middleware: use config consistently in https_fixup 070b8c39736f did for unknown reasons introduce a use of the global kallithea.CONFIG . Instead, consistently use the application config object that has been passed.

html: align formatting of edit_perms templates

html: clarify type of button elements - make it clear if we really want "submit" This might fix some real problems.

usergroup: fix adding permission Clicking "Add new" on /_admin/user_groups/1/edit/perms would flicker the input fields, and then show "User group permissions updated". That turns out to be because HTML button tags default to 'submit' inside forms, and in this place (but not for user or repo group permissions) we didn't specify the button type as 'button'. There might be other similar problems.