upstream/mercurial-mirror Files · tests/mockblackbox.py

phabricator: warn if unable to amend, instead of aborting after posting...

phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

Yuya Nishihara - - Load All Authors

File last commit:

r37138:a8a902d7 default


                r41198:0101a35d

default

Download file

             mockblackbox.py
        
                    15 lines
            
             | 369 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / mockblackbox.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Robert Stanca
    
py3: use absolute_import in mockblackbox.py

              r28943
            
      from __future__ import absolute_import

        Yuya Nishihara
    
procutil: bulk-replace function calls to point to new module

              r37138
            
      from mercurial.utils import (

          procutil,

        Robert Stanca
    
py3: use absolute_import in mockblackbox.py

              r28943
            
      )

        Gregory Szorc
    
tests: move mock blackbox extension into own file...

              r24705
            
        Boris Feld
    
devel: update blackbox to use default-date...

              r32412
            
      # XXX: we should probably offer a devel option to do this in blackbox directly

        Gregory Szorc
    
tests: move mock blackbox extension into own file...

              r24705
            
      def getuser():

        Gregory Szorc
    
py3: use b'' in mockblackbox.py...

              r36122
            
          return b'bob'

        timeless
    
tests: mock getpid to reduce glob usage...

              r28028
            
      def getpid():

          return 5000

        Gregory Szorc
    
tests: move mock blackbox extension into own file...

              r24705
            
      # mock the date and user apis so the output is always the same

      def uisetup(ui):

        Yuya Nishihara
    
procutil: bulk-replace function calls to point to new module

              r37138
            
          procutil.getuser = getuser

          procutil.getpid = getpid

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Robert Stanca py3: use absolute_import in mockblackbox.py	r28943	from __future__ import absolute_import
Yuya Nishihara procutil: bulk-replace function calls to point to new module	r37138	from mercurial.utils import (
		procutil,
Robert Stanca py3: use absolute_import in mockblackbox.py	r28943	)
Gregory Szorc tests: move mock blackbox extension into own file...	r24705
Boris Feld devel: update blackbox to use default-date...	r32412	# XXX: we should probably offer a devel option to do this in blackbox directly
Gregory Szorc tests: move mock blackbox extension into own file...	r24705	def getuser():
Gregory Szorc py3: use b'' in mockblackbox.py...	r36122	return b'bob'
timeless tests: mock getpid to reduce glob usage...	r28028	def getpid():
		return 5000
Gregory Szorc tests: move mock blackbox extension into own file...	r24705
		# mock the date and user apis so the output is always the same
		def uisetup(ui):
Yuya Nishihara procutil: bulk-replace function calls to point to new module	r37138	procutil.getuser = getuser
		procutil.getpid = getpid