##// END OF EJS Templates
phabricator: warn if unable to amend, instead of aborting after posting...
phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

File last commit:

r40809:06057261 default
r41198:0101a35d default
Show More
seq.py
36 lines | 770 B | text/x-python | PythonLexer
Matt Harbison
tests: introduce 'seq.py' as a portable replacement for 'seq'...
r24360 #!/usr/bin/env python
#
# A portable replacement for 'seq'
#
# Usage:
# seq STOP [1, STOP] stepping by 1
# seq START STOP [START, STOP] stepping by 1
# seq START STEP STOP [START, STOP] stepping by STEP
Robert Stanca
py3: use print_function in seq.py
r28722 from __future__ import absolute_import, print_function
Matt Harbison
tests: apply binary mode to output in seq.py...
r40809 import os
Matt Harbison
tests: introduce 'seq.py' as a portable replacement for 'seq'...
r24360 import sys
Matt Harbison
tests: apply binary mode to output in seq.py...
r40809 try:
import msvcrt
msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)
msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)
msvcrt.setmode(sys.stderr.fileno(), os.O_BINARY)
except ImportError:
pass
Pulkit Goyal
py3: alias xrange to range in tests/seq.py...
r35151 if sys.version_info[0] >= 3:
xrange = range
Matt Harbison
tests: introduce 'seq.py' as a portable replacement for 'seq'...
r24360 start = 1
if len(sys.argv) > 2:
start = int(sys.argv[1])
step = 1
if len(sys.argv) > 3:
step = int(sys.argv[2])
stop = int(sys.argv[-1]) + 1
for i in xrange(start, stop, step):
Robert Stanca
py3: use print_function in seq.py
r28722 print(i)