##// END OF EJS Templates
phabricator: warn if unable to amend, instead of aborting after posting...
phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

File last commit:

r40199:9f0ee4a6 default
r41198:0101a35d default
Show More
test-check-code.t
69 lines | 1.9 KiB | text/troff | Tads3Lexer
/ tests / test-check-code.t
Pierre-Yves David
tests: move the '-hg' postfix for all style tests...
r27368 #require test-repo
timeless
tests: silence test-repo obsolete warning...
r29219 $ . "$TESTDIR/helpers-testrepo.sh"
Pierre-Yves David
tests: move the '-hg' postfix for all style tests...
r27368 $ check_code="$TESTDIR"/../contrib/check-code.py
$ cd "$TESTDIR"/..
New errors are not allowed. Warnings are strongly discouraged.
(The writing "no-che?k-code" is for not skipping this file when checking.)
Siddharth Agarwal
tests: disable lints on mercurial/thirdparty...
r34396 $ testrepohg locate \
> -X contrib/python-zstandard \
> -X hgext/fsmonitor/pywatchman \
> -X mercurial/thirdparty \
> | sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false
Pierre-Yves David
tests: move the '-hg' postfix for all style tests...
r27368 Skipping i18n/polib.py it has no-che?k-code (glob)
Gregory Szorc
statprof: vendor statprof.py...
r30253 Skipping mercurial/statprof.py it has no-che?k-code (glob)
Gregory Szorc
tests: add tests for poorly behaving HTTP server...
r32001 Skipping tests/badserverext.py it has no-che?k-code (glob)
Gregory Szorc
tests: add test that @commands in debugcommands.py are sorted...
r30540
@commands in debugcommands.py should be in alphabetical order.
>>> import re
>>> commands = []
>>> with open('mercurial/debugcommands.py', 'rb') as fh:
... for line in fh:
Augie Fackler
tests: add missing b'' prefix in test-check-code.t...
r39092 ... m = re.match(b"^@command\('([a-z]+)", line)
Gregory Szorc
tests: add test that @commands in debugcommands.py are sorted...
r30540 ... if m:
... commands.append(m.group(1))
>>> scommands = list(sorted(commands))
>>> for i, command in enumerate(scommands):
... if command != commands[i]:
... print('commands in debugcommands.py not sorted; first differing '
... 'command is %s; expected %s' % (commands[i], command))
... break
Jun Wu
test-check-code: prevent files being added to the root directory...
r31726
Prevent adding new files in the root directory accidentally.
Yuya Nishihara
tests: alias syshg and syshgenv so they can be switched conditionally
r33199 $ testrepohg files 'glob:*'
Alex Gaynor
phabricator: include the suggested arc config in the repo...
r33584 .arcconfig
Augie Fackler
clang-format: configuration for the clang-format source formatter...
r34799 .clang-format
Jun Wu
test-check-code: prevent files being added to the root directory...
r31726 .editorconfig
.hgignore
.hgsigs
.hgtags
av6
hgweb: add .jshintrc with some basic rules...
r35163 .jshintrc
Jun Wu
test-check-code: prevent files being added to the root directory...
r31726 CONTRIBUTING
CONTRIBUTORS
COPYING
Makefile
David Demelier
doc: rename README to README.rst...
r34580 README.rst
Jun Wu
test-check-code: prevent files being added to the root directory...
r31726 hg
hgeditor
hgweb.cgi
setup.py
Yuya Nishihara
test-check-code: prevent from adding Python modules shadowed by ancient C
r37822
Prevent adding modules which could be shadowed by ancient .so/.dylib.
$ testrepohg files \
> mercurial/base85.py \
> mercurial/bdiff.py \
> mercurial/diffhelpers.py \
> mercurial/mpatch.py \
> mercurial/osutil.py \
> mercurial/parsers.py \
> mercurial/zstd.py
[1]
Augie Fackler
tests: ensure the python 3 passing test list stays sorted...
r40199
Keep python3 tests sorted:
$ sort < contrib/python3-whitelist > $TESTTMP/py3sorted
$ cmp contrib/python3-whitelist $TESTTMP/py3sorted || echo 'Please sort passing tests!'