upstream/mercurial-mirror Files · tests/test-extra-filelog-entry.t

phabricator: warn if unable to amend, instead of aborting after posting...

phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

Gregory Szorc - - Load All Authors

File last commit:

r37301:d4e62df1 default


                r41198:0101a35d

default

Download file

             test-extra-filelog-entry.t
        
                    21 lines
            
             | 388 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-extra-filelog-entry.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Martin Geisler
    
tests: added a short description to issue numbers...

              r12399
            
      Issue351: mq: qrefresh can create extra revlog entry

        Adrian Buehlmann
    
tests: unify test-extra-filelog-entry

              r12305
            
        $ echo "[extensions]" >> $HGRCPATH

        $ echo "mq=" >> $HGRCPATH

        $ hg init

        $ hg qinit

        $ echo b > b

        $ hg ci -A -m foo

        adding b

        $ echo cc > b

        $ hg qnew -f foo.diff

        $ echo b > b

        $ hg qrefresh

        Sune Foldager
    
tests: fix deprecated use of hg debugdata/debugindex...

              r14182
            
        $ hg debugindex b

        Gregory Szorc
    
debugcommands: drop offset and length from debugindex by default...

              r37301
            
           rev linkrev nodeid       p1           p2

             0       0 1e88685f5dde 000000000000 000000000000

        Adrian Buehlmann
    
tests: unify test-extra-filelog-entry

              r12305

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Martin Geisler tests: added a short description to issue numbers...	r12399	Issue351: mq: qrefresh can create extra revlog entry
Adrian Buehlmann tests: unify test-extra-filelog-entry	r12305
		$ echo "[extensions]" >> $HGRCPATH
		$ echo "mq=" >> $HGRCPATH

		$ hg init
		$ hg qinit

		$ echo b > b
		$ hg ci -A -m foo
		adding b

		$ echo cc > b
		$ hg qnew -f foo.diff
		$ echo b > b
		$ hg qrefresh

Sune Foldager tests: fix deprecated use of hg debugdata/debugindex...	r14182	$ hg debugindex b
Gregory Szorc debugcommands: drop offset and length from debugindex by default...	r37301	rev linkrev nodeid p1 p2
		0 0 1e88685f5dde 000000000000 000000000000
Adrian Buehlmann tests: unify test-extra-filelog-entry	r12305