upstream/mercurial-mirror Files · tests/test-hg-parseurl.py

phabricator: warn if unable to amend, instead of aborting after posting...

phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

Augie Fackler - - Load All Authors

File last commit:

r37732:5dd71e9a default


                r41198:0101a35d

default

Download file

             test-hg-parseurl.py
        
                    34 lines
            
             | 1.4 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / test-hg-parseurl.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Robert Stanca
    
py3: use print_function in test-hg-parseurl.py

              r28746
            
      from __future__ import absolute_import, print_function

        Yuya Nishihara
    
test-hg-parseurl: stop direct symbol import of mercurial.hg.parseurl

              r28806
            
        Augie Fackler
    
tests: port test-hg-parseurl.py to unittest...

              r37731
            
      import unittest

        Yuya Nishihara
    
test-hg-parseurl: stop direct symbol import of mercurial.hg.parseurl

              r28806
            
      from mercurial import (

          hg,

        Robert Stanca
    
py3: use absolute_import in test-hg-parseurl.py

              r28745
            
      )

        Martijn Pieters
    
hg: allow hg.parseurl(url, None)...

              r8174
            
        Augie Fackler
    
tests: port test-hg-parseurl.py to unittest...

              r37731
            
      class ParseRequestTests(unittest.TestCase):

          def testparse(self):

        Martijn Pieters
    
hg: allow hg.parseurl(url, None)...

              r8174
            
        Augie Fackler
    
tests: add b prefixes to test-hg-parseurl.py...

              r37732
            
              self.assertEqual(hg.parseurl(b'http://example.com/no/anchor'),

                               (b'http://example.com/no/anchor', (None, [])))

              self.assertEqual(hg.parseurl(b'http://example.com/an/anchor#foo'),

                               (b'http://example.com/an/anchor', (b'foo', [])))

        Augie Fackler
    
tests: port test-hg-parseurl.py to unittest...

              r37731
            
              self.assertEqual(

        Augie Fackler
    
tests: add b prefixes to test-hg-parseurl.py...

              r37732
            
                  hg.parseurl(b'http://example.com/no/anchor/branches', [b'foo']),

                  (b'http://example.com/no/anchor/branches', (None, [b'foo'])))

        Augie Fackler
    
tests: port test-hg-parseurl.py to unittest...

              r37731
            
              self.assertEqual(

        Augie Fackler
    
tests: add b prefixes to test-hg-parseurl.py...

              r37732
            
                  hg.parseurl(b'http://example.com/an/anchor/branches#bar', [b'foo']),

                  (b'http://example.com/an/anchor/branches', (b'bar', [b'foo'])))

        Augie Fackler
    
tests: port test-hg-parseurl.py to unittest...

              r37731
            
              self.assertEqual(hg.parseurl(

        Augie Fackler
    
tests: add b prefixes to test-hg-parseurl.py...

              r37732
            
                  b'http://example.com/an/anchor/branches-None#foo', None),

                  (b'http://example.com/an/anchor/branches-None', (b'foo', [])))

              self.assertEqual(hg.parseurl(b'http://example.com/'),

                               (b'http://example.com/', (None, [])))

              self.assertEqual(hg.parseurl(b'http://example.com'),

                               (b'http://example.com/', (None, [])))

              self.assertEqual(hg.parseurl(b'http://example.com#foo'),

                               (b'http://example.com/', (b'foo', [])))

        Augie Fackler
    
tests: port test-hg-parseurl.py to unittest...

              r37731
            
      if __name__ == '__main__':

          import silenttestrunner

          silenttestrunner.main(__name__)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Robert Stanca py3: use print_function in test-hg-parseurl.py	r28746	from __future__ import absolute_import, print_function
Yuya Nishihara test-hg-parseurl: stop direct symbol import of mercurial.hg.parseurl	r28806
Augie Fackler tests: port test-hg-parseurl.py to unittest...	r37731	import unittest

Yuya Nishihara test-hg-parseurl: stop direct symbol import of mercurial.hg.parseurl	r28806	from mercurial import (
		hg,
Robert Stanca py3: use absolute_import in test-hg-parseurl.py	r28745	)
Martijn Pieters hg: allow hg.parseurl(url, None)...	r8174
Augie Fackler tests: port test-hg-parseurl.py to unittest...	r37731	class ParseRequestTests(unittest.TestCase):
		def testparse(self):
Martijn Pieters hg: allow hg.parseurl(url, None)...	r8174
Augie Fackler tests: add b prefixes to test-hg-parseurl.py...	r37732	self.assertEqual(hg.parseurl(b'http://example.com/no/anchor'),
		(b'http://example.com/no/anchor', (None, [])))
		self.assertEqual(hg.parseurl(b'http://example.com/an/anchor#foo'),
		(b'http://example.com/an/anchor', (b'foo', [])))
Augie Fackler tests: port test-hg-parseurl.py to unittest...	r37731	self.assertEqual(
Augie Fackler tests: add b prefixes to test-hg-parseurl.py...	r37732	hg.parseurl(b'http://example.com/no/anchor/branches', [b'foo']),
		(b'http://example.com/no/anchor/branches', (None, [b'foo'])))
Augie Fackler tests: port test-hg-parseurl.py to unittest...	r37731	self.assertEqual(
Augie Fackler tests: add b prefixes to test-hg-parseurl.py...	r37732	hg.parseurl(b'http://example.com/an/anchor/branches#bar', [b'foo']),
		(b'http://example.com/an/anchor/branches', (b'bar', [b'foo'])))
Augie Fackler tests: port test-hg-parseurl.py to unittest...	r37731	self.assertEqual(hg.parseurl(
Augie Fackler tests: add b prefixes to test-hg-parseurl.py...	r37732	b'http://example.com/an/anchor/branches-None#foo', None),
		(b'http://example.com/an/anchor/branches-None', (b'foo', [])))
		self.assertEqual(hg.parseurl(b'http://example.com/'),
		(b'http://example.com/', (None, [])))
		self.assertEqual(hg.parseurl(b'http://example.com'),
		(b'http://example.com/', (None, [])))
		self.assertEqual(hg.parseurl(b'http://example.com#foo'),
		(b'http://example.com/', (b'foo', [])))
Augie Fackler tests: port test-hg-parseurl.py to unittest...	r37731
		if __name__ == '__main__':
		import silenttestrunner
		silenttestrunner.main(__name__)