upstream/mercurial-mirror Files · tests/test-pull-permission.t

phabricator: warn if unable to amend, instead of aborting after posting...

phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

Meirambek Omyrzak - - Load All Authors

File last commit:

r39525:f1186c29 default


                r41198:0101a35d

default

Download file

             test-pull-permission.t
        
                    33 lines
            
             | 661 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-pull-permission.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Matt Mackall
    
tests: change some #ifs to #requires

              r22047
            
      #require unix-permissions no-root

        Mads Kiilerich
    
tests: add missing 'hghave unix-permissions'

              r15516
            
        Martin Geisler
    
tests: remove redundant mkdir...

              r13956
            
        $ hg init a

        Adrian Buehlmann
    
combine tests

              r12279
            
        $ cd a

        $ echo foo > b

        $ hg add b

        $ hg ci -m "b"

        $ chmod -w .hg/store

        $ cd ..

        $ hg clone a b

        requesting all changes

        adding changesets

        adding manifests

        adding file changes

        added 1 changesets with 1 changes to 1 files

        Denis Laxalde
    
transaction-summary: show the range of new revisions upon pull/unbundle (BC)...

              r34662
            
        new changesets 97310831fa1a

        Adrian Buehlmann
    
combine tests

              r12279
            
        updating to branch default

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ chmod +w a/.hg/store # let test clean up

        $ cd b

        $ hg verify

        checking changesets

        checking manifests

        crosschecking files in changesets and manifests

        checking files

        Meirambek Omyrzak
    
verify: make output less confusing (issue5924)...

              r39525
            
        checked 1 changesets with 1 changes to 1 files

        Adrian Buehlmann
    
combine tests

              r12279
            
        Mads Kiilerich
    
tests: add missing trailing 'cd ..'...

              r16913
            
        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Matt Mackall tests: change some #ifs to #requires	r22047	#require unix-permissions no-root
Mads Kiilerich tests: add missing 'hghave unix-permissions'	r15516
Martin Geisler tests: remove redundant mkdir...	r13956	$ hg init a
Adrian Buehlmann combine tests	r12279	$ cd a
		$ echo foo > b
		$ hg add b
		$ hg ci -m "b"

		$ chmod -w .hg/store

		$ cd ..

		$ hg clone a b
		requesting all changes
		adding changesets
		adding manifests
		adding file changes
		added 1 changesets with 1 changes to 1 files
Denis Laxalde transaction-summary: show the range of new revisions upon pull/unbundle (BC)...	r34662	new changesets 97310831fa1a
Adrian Buehlmann combine tests	r12279	updating to branch default
		1 files updated, 0 files merged, 0 files removed, 0 files unresolved

		$ chmod +w a/.hg/store # let test clean up

		$ cd b
		$ hg verify
		checking changesets
		checking manifests
		crosschecking files in changesets and manifests
		checking files
Meirambek Omyrzak verify: make output less confusing (issue5924)...	r39525	checked 1 changesets with 1 changes to 1 files
Adrian Buehlmann combine tests	r12279
Mads Kiilerich tests: add missing trailing 'cd ..'...	r16913	$ cd ..