##// END OF EJS Templates
upstream » mercurial-mirror
RSS

Clone from https://www.mercurial-scm.org/repo/hg-all

phabricator: warn if unable to amend, instead of aborting after posting...
phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.
Boris Feld - - Load All Authors

File last commit:

r39516:89630d0b default
r41198:0101a35d default
Show More
test-symlink-os-yes-fs-no.py.out
12 lines | 416 B | text/plain | TextLexer
/ tests / test-symlink-os-yes-fs-no.py.out
History | Source | Raw |Copy content |Copy permalink
Dov Feldstern
test symlinks on symlink-capable os but non-capable filesystem (issue1149)...
 r6879 adding changesets
adding manifests
adding file changes
added 1 changesets with 4 changes to 4 files
Boris Feld
phase: report number of non-public changeset alongside the new range...
 r39516 new changesets d326ae2d01ee (1 drafts)
Dov Feldstern
test symlinks on symlink-capable os but non-capable filesystem (issue1149)...
 r6879 4 files updated, 0 files merged, 0 files removed, 0 files unresolved
Martin Geisler
dirstate: ignore symlinks when fs cannot handle them (issue1888)...
 r11769 adding changesets
adding manifests
adding file changes
added 1 changesets with 4 changes to 4 files
Boris Feld
phase: report number of non-public changeset alongside the new range...
 r39516 new changesets d326ae2d01ee (1 drafts)
Martin Geisler
dirstate: ignore symlinks when fs cannot handle them (issue1888)...
 r11769 4 files updated, 0 files merged, 0 files removed, 0 files unresolved