##// END OF EJS Templates
phabricator: warn if unable to amend, instead of aborting after posting...
phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

File last commit:

r37864:b4b7427b default
r41198:0101a35d default
Show More
test-unbundlehash.t
43 lines | 1.4 KiB | text/troff | Tads3Lexer
/ tests / test-unbundlehash.t
Shuhei Takahashi
wireproto: allow unbundle with hashed heads parameter (issue2126)...
r13942 Test wire protocol unbundle with hashed heads (capability: unbundlehash)
Pierre-Yves David
test: lock test-unbundlehash to bundle1 usage...
r25374 $ cat << EOF >> $HGRCPATH
Pierre-Yves David
tests: use 'legacy.exchange' option in various bundle1 tests...
r29686 > [devel]
Pierre-Yves David
test: lock test-unbundlehash to bundle1 usage...
r25374 > # This tests is intended for bundle1 only.
> # bundle2 carries the head information inside the bundle itself and
> # always uses 'force' as the heads value.
Pierre-Yves David
tests: use 'legacy.exchange' option in various bundle1 tests...
r29686 > legacy.exchange = bundle1
Pierre-Yves David
test: lock test-unbundlehash to bundle1 usage...
r25374 > EOF
Shuhei Takahashi
wireproto: allow unbundle with hashed heads parameter (issue2126)...
r13942 Create a remote repository.
$ hg init remote
$ hg serve -R remote --config web.push_ssl=False --config web.allow_push=* -p $HGPORT -d --pid-file=hg1.pid -E error.log -A access.log
$ cat hg1.pid >> $DAEMON_PIDS
Clone the repository and push a change.
$ hg clone http://localhost:$HGPORT/ local
no changes found
updating to branch default
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ touch local/README
$ hg ci -R local -A -m hoge
adding README
$ hg push -R local
pushing to http://localhost:$HGPORT/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
Ensure hashed heads format is used.
The hash here is always the same since the remote repository only has the null head.
$ cat access.log | grep unbundle
timeless
tests: tolerate http2...
r28996 * - - [*] "POST /?cmd=unbundle HTTP/1.1" 200 - x-hgarg-1:heads=686173686564+6768033e216468247bd031a0a2d9876d79818f8f* (glob)
Patrick Mezard
tests: enable more server tests on Windows
r17539
Explicitly kill daemons to let the test exit on Windows
Matt Mackall
tests: drop DAEMON_PIDS from killdaemons calls
r25474 $ killdaemons.py
Patrick Mezard
tests: enable more server tests on Windows
r17539