upstream/mercurial-mirror Files · mercurial/templates/monoblue/index.tmpl

hgweb: remove support for POST form data (BC)...

hgweb: remove support for POST form data (BC) Previously, we called out to cgi.parse(), which for POST requests parsed multipart/form-data and application/x-www-form-urlencoded Content-Type requests for form data, combined it with query string parameters, returned a union of the values. As far as I know, nothing in Mercurial actually uses this mechanism to submit data to the HTTP server. The wire protocol has its own mechanism for passing parameters. And the web interface only does GET requests. Removing support for parsing POST data doesn't break any tests. Another reason to not like this feature is that cgi.parse() may modify the QUERY_STRING environment variable as a side-effect. In addition, it merges both POST data and the query string into one data structure. This prevents consumers from knowing whether a variable came from the query string or POST data. That can matter for some operations. I suspect we use cgi.parse() because back when this code was initially implemented, it was the function that was readily available. In other words, I don't think there was conscious choice to support POST data: we just got it because cgi.parse() supported it. Since nothing uses the feature and it is untested, let's remove support for parsing POST form data. We can add it back in easily enough if we need it in the future. .. bc:: Hgweb no longer reads form data in POST requests from multipart/form-data and application/x-www-form-urlencoded requests. Arguments should be specified as URL path components or in the query string in the URL instead. Differential Revision: https://phab.mercurial-scm.org/D2774

Gregory Szorc - - Load All Authors

File last commit:

r30765:eb7de21b default


                r36874:01f6bba6

default

Download file

             index.tmpl
        
                    34 lines
            
             | 945 B
            
                | application/x-cheetah
            
             |
                CheetahLexer
            
             / mercurial / templates / monoblue / index.tmpl
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Dan Villiom Podlaski Christiansen
    
setup: install translation files as package data...

              r9999
            
      {header}

        av6
    
monoblue: don't try to show repo on hgwebdir index page...

              r25746
            
          <title>Mercurial repositories index</title>

        Dan Villiom Podlaski Christiansen
    
setup: install translation files as package data...

              r9999
            
      </head>

      <body>

      <div id="container">

          <div class="page-header">

        Angel Ezquerra <angel.ezquerra at gmail.com>
    
hgweb: add a "URL breadcrumb" to the index and repository pages...

              r18258
            
              <h1 class="breadcrumb"><a href="/">Mercurial</a> {pathdef%breadcrumb}</h1>

        Dan Villiom Podlaski Christiansen
    
setup: install translation files as package data...

              r9999
            
              <ul class="page-nav">

              </ul>

          </div>

        Thomas Arendsen Hein
    
trailing spaces (and one stray tab)

              r10575
            
        Dan Villiom Podlaski Christiansen
    
setup: install translation files as package data...

              r9999
            
          <table cellspacing="0">

              <tr>

                  <td><a href="?sort={sort_name}">Name</a></td>

                  <td><a href="?sort={sort_description}">Description</a></td>

                  <td><a href="?sort={sort_contact}">Contact</a></td>

        Dan Villiom Podlaski Christiansen
    
templates: rename `Last change' column in hgwebdir repository list....

              r10301
            
                  <td><a href="?sort={sort_lastchange}">Last modified</a></td>

        Dan Villiom Podlaski Christiansen
    
setup: install translation files as package data...

              r9999
            
                  <td>&nbsp;</td>

                  <td>&nbsp;</td>

              </tr>

              {entries%indexentry}

          </table>

          <div class="page-footer">

              {motd}

          </div>

          <div id="powered-by">

        Thomas Arendsen Hein
    
hgweb: urlescape all urls, HTML escape repo/tag/branch/... names...

              r18526
            
              <p><a href="{logourl}" title="Mercurial"><img src="{staticurl|urlescape}{logoimg}" width=75 height=90 border=0 alt="mercurial"></a></p>

        Dan Villiom Podlaski Christiansen
    
setup: install translation files as package data...

              r9999
            
          </div>

      </div>

      </body>

      </html>

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Dan Villiom Podlaski Christiansen setup: install translation files as package data...	r9999	{header}
av6 monoblue: don't try to show repo on hgwebdir index page...	r25746	<title>Mercurial repositories index</title>
Dan Villiom Podlaski Christiansen setup: install translation files as package data...	r9999	</head>

		<body>
		<div id="container">
		<div class="page-header">
Angel Ezquerra <angel.ezquerra at gmail.com> hgweb: add a "URL breadcrumb" to the index and repository pages...	r18258	<h1 class="breadcrumb"><a href="/">Mercurial</a> {pathdef%breadcrumb}</h1>
Dan Villiom Podlaski Christiansen setup: install translation files as package data...	r9999	<ul class="page-nav">
		</ul>
		</div>
Thomas Arendsen Hein trailing spaces (and one stray tab)	r10575
Dan Villiom Podlaski Christiansen setup: install translation files as package data...	r9999	<table cellspacing="0">
		<tr>
		<td><a href="?sort={sort_name}">Name</a></td>
		<td><a href="?sort={sort_description}">Description</a></td>
		<td><a href="?sort={sort_contact}">Contact</a></td>
Dan Villiom Podlaski Christiansen templates: rename `Last change' column in hgwebdir repository list....	r10301	<td><a href="?sort={sort_lastchange}">Last modified</a></td>
Dan Villiom Podlaski Christiansen setup: install translation files as package data...	r9999	<td> </td>
		<td> </td>
		</tr>
		{entries%indexentry}
		</table>
		<div class="page-footer">
		{motd}
		</div>

		<div id="powered-by">
Thomas Arendsen Hein hgweb: urlescape all urls, HTML escape repo/tag/branch/... names...	r18526	<p><a href="{logourl}" title="Mercurial"><img src="{staticurl\|urlescape}{logoimg}" width=75 height=90 border=0 alt="mercurial"></a></p>
Dan Villiom Podlaski Christiansen setup: install translation files as package data...	r9999	</div>

		</div>
		</body>
		</html>