##// END OF EJS Templates
wireprotov2: implement commands as a generator of objects...
wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472

File last commit:

r38234:a1c0873a default
r39595:07b58266 default
Show More
fuzzutil.cc
27 lines | 922 B | text/x-c | CppLexer
Augie Fackler
fuzz: extract some common utilities and use modern C++ idioms...
r38191 #include "fuzzutil.h"
Yuya Nishihara
fuzz: fix use of undeclared function memcpy()
r38234 #include <cstring>
Augie Fackler
fuzz: extract some common utilities and use modern C++ idioms...
r38191 #include <utility>
Augie Fackler
fuzzutil: make it possible to use absl when C++17 isn't supported...
r38192 contrib::optional<two_inputs> SplitInputs(const uint8_t *Data, size_t Size)
Augie Fackler
fuzz: extract some common utilities and use modern C++ idioms...
r38191 {
if (!Size) {
Augie Fackler
fuzzutil: make it possible to use absl when C++17 isn't supported...
r38192 return contrib::nullopt;
Augie Fackler
fuzz: extract some common utilities and use modern C++ idioms...
r38191 }
// figure out a random point in [0, Size] to split our input.
size_t left_size = (Data[0] / 255.0) * (Size - 1);
// Copy inputs to new allocations so if bdiff over-reads
// AddressSanitizer can detect it.
std::unique_ptr<char[]> left(new char[left_size]);
Yuya Nishihara
fuzz: fix use of undeclared function memcpy()
r38234 std::memcpy(left.get(), Data + 1, left_size);
Augie Fackler
fuzz: extract some common utilities and use modern C++ idioms...
r38191 // right starts at the next byte after left ends
size_t right_size = Size - (left_size + 1);
std::unique_ptr<char[]> right(new char[right_size]);
Yuya Nishihara
fuzz: fix use of undeclared function memcpy()
r38234 std::memcpy(right.get(), Data + 1 + left_size, right_size);
Augie Fackler
fuzz: extract some common utilities and use modern C++ idioms...
r38191 LOG(2) << "inputs are " << left_size << " and " << right_size
<< " bytes" << std::endl;
two_inputs result = {std::move(right), right_size, std::move(left),
left_size};
return result;
}