##// END OF EJS Templates
upstream » mercurial-mirror
RSS

Clone from https://www.mercurial-scm.org/repo/hg-all

wireprotov2: implement commands as a generator of objects...
wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472
Yuya Nishihara - - Load All Authors

File last commit:

r33927:f4433f27 default
r39595:07b58266 default
Show More
compat.h
45 lines | 849 B | text/x-c | CLexer
/ mercurial / compat.h
History | Source | Raw |Copy content |Copy permalink
Maciej Fijalkowski
internals: move the bitmanipulation routines into its own file...
 r29444 #ifndef _HG_COMPAT_H_
#define _HG_COMPAT_H_
#ifdef _WIN32
#ifdef _MSC_VER
/* msvc 6.0 has problems */
#define inline __inline
Maciej Fijalkowski
compat: provide a declaration of ssize_t, for MS windows
 r29521 #if defined(_WIN64)
typedef __int64 ssize_t;
Yuya Nishihara
encoding: add function to test if a str consists of ASCII characters...
 r33927 typedef unsigned __int64 uintptr_t;
Maciej Fijalkowski
compat: provide a declaration of ssize_t, for MS windows
 r29521 #else
Yuya Nishihara
compat: define ssize_t as int on 32bit Windows, silences C4142 warning...
 r29549 typedef int ssize_t;
Yuya Nishihara
encoding: add function to test if a str consists of ASCII characters...
 r33927 typedef unsigned int uintptr_t;
Maciej Fijalkowski
compat: provide a declaration of ssize_t, for MS windows
 r29521 #endif
Maciej Fijalkowski
internals: move the bitmanipulation routines into its own file...
 r29444 typedef signed char int8_t;
typedef short int16_t;
typedef long int32_t;
typedef __int64 int64_t;
typedef unsigned char uint8_t;
typedef unsigned short uint16_t;
typedef unsigned long uint32_t;
typedef unsigned __int64 uint64_t;
#else
#include <stdint.h>
#endif
#else
/* not windows */
#include <sys/types.h>
#if defined __BEOS__ && !defined __HAIKU__
#include <ByteOrder.h>
#else
#include <arpa/inet.h>
#endif
#include <inttypes.h>
#endif
#if defined __hpux || defined __SUNPRO_C || defined _AIX
#define inline
#endif
#ifdef __linux
#define inline __inline
#endif
#endif