upstream/mercurial-mirror Files · mercurial/mpatch.h

wireprotov2: implement commands as a generator of objects...

wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472

Augie Fackler - - Load All Authors

File last commit:

r34801:76135583 default


                r39595:07b58266

default

Download file

             mpatch.h
        
                    26 lines
            
             | 717 B
            
                | text/x-c
            
             |
                CLexer
            
             / mercurial / mpatch.h
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Maciej Fijalkowski
    
mpatch: split mpatch into two files

              r29693
            
      #ifndef _HG_MPATCH_H_

      #define _HG_MPATCH_H_

        Maciej Fijalkowski
    
mpatch: remove dependency on Python.h in mpatch.c...

              r29694
            
      #define MPATCH_ERR_NO_MEM -3

      #define MPATCH_ERR_CANNOT_BE_DECODED -2

      #define MPATCH_ERR_INVALID_PATCH -1

        Maciej Fijalkowski
    
mpatch: split mpatch into two files

              r29693
            
      struct mpatch_frag {

      	int start, end, len;

      	const char *data;

      };

      struct mpatch_flist {

      	struct mpatch_frag *base, *head, *tail;

      };

        Augie Fackler
    
mpatch: reformat function prototypes with clang-format...

              r34801
            
      int mpatch_decode(const char *bin, ssize_t len, struct mpatch_flist **res);

        Maciej Fijalkowski
    
mpatch: split mpatch into two files

              r29693
            
      ssize_t mpatch_calcsize(ssize_t len, struct mpatch_flist *l);

      void mpatch_lfree(struct mpatch_flist *a);

      int mpatch_apply(char *buf, const char *orig, ssize_t len,

        Augie Fackler
    
mpatch: reformat function prototypes with clang-format...

              r34801
            
                       struct mpatch_flist *l);

      struct mpatch_flist *

      mpatch_fold(void *bins, struct mpatch_flist *(*get_next_item)(void *, ssize_t),

                  ssize_t start, ssize_t end);

        Maciej Fijalkowski
    
mpatch: split mpatch into two files

              r29693
            
      #endif

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Maciej Fijalkowski mpatch: split mpatch into two files	r29693	#ifndef _HG_MPATCH_H_
		#define _HG_MPATCH_H_

Maciej Fijalkowski mpatch: remove dependency on Python.h in mpatch.c...	r29694	#define MPATCH_ERR_NO_MEM -3
		#define MPATCH_ERR_CANNOT_BE_DECODED -2
		#define MPATCH_ERR_INVALID_PATCH -1

Maciej Fijalkowski mpatch: split mpatch into two files	r29693	struct mpatch_frag {
		int start, end, len;
		const char *data;
		};

		struct mpatch_flist {
		struct mpatch_frag base, head, *tail;
		};

Augie Fackler mpatch: reformat function prototypes with clang-format...	r34801	int mpatch_decode(const char bin, ssize_t len, struct mpatch_flist *res);
Maciej Fijalkowski mpatch: split mpatch into two files	r29693	ssize_t mpatch_calcsize(ssize_t len, struct mpatch_flist *l);
		void mpatch_lfree(struct mpatch_flist *a);
		int mpatch_apply(char buf, const char orig, ssize_t len,
Augie Fackler mpatch: reformat function prototypes with clang-format...	r34801	struct mpatch_flist *l);
		struct mpatch_flist *
		mpatch_fold(void bins, struct mpatch_flist (get_next_item)(void , ssize_t),
		ssize_t start, ssize_t end);
Maciej Fijalkowski mpatch: split mpatch into two files	r29693
		#endif