##// END OF EJS Templates
wireprotov2: implement commands as a generator of objects...
wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472

File last commit:

r39092:850fe0b9 default
r39595:07b58266 default
Show More
test-check-code.t
65 lines | 1.8 KiB | text/troff | Tads3Lexer
/ tests / test-check-code.t
Pierre-Yves David
tests: move the '-hg' postfix for all style tests...
r27368 #require test-repo
timeless
tests: silence test-repo obsolete warning...
r29219 $ . "$TESTDIR/helpers-testrepo.sh"
Pierre-Yves David
tests: move the '-hg' postfix for all style tests...
r27368 $ check_code="$TESTDIR"/../contrib/check-code.py
$ cd "$TESTDIR"/..
New errors are not allowed. Warnings are strongly discouraged.
(The writing "no-che?k-code" is for not skipping this file when checking.)
Siddharth Agarwal
tests: disable lints on mercurial/thirdparty...
r34396 $ testrepohg locate \
> -X contrib/python-zstandard \
> -X hgext/fsmonitor/pywatchman \
> -X mercurial/thirdparty \
> | sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false
Pierre-Yves David
tests: move the '-hg' postfix for all style tests...
r27368 Skipping i18n/polib.py it has no-che?k-code (glob)
Gregory Szorc
statprof: vendor statprof.py...
r30253 Skipping mercurial/statprof.py it has no-che?k-code (glob)
Gregory Szorc
tests: add tests for poorly behaving HTTP server...
r32001 Skipping tests/badserverext.py it has no-che?k-code (glob)
Gregory Szorc
tests: add test that @commands in debugcommands.py are sorted...
r30540
@commands in debugcommands.py should be in alphabetical order.
>>> import re
>>> commands = []
>>> with open('mercurial/debugcommands.py', 'rb') as fh:
... for line in fh:
Augie Fackler
tests: add missing b'' prefix in test-check-code.t...
r39092 ... m = re.match(b"^@command\('([a-z]+)", line)
Gregory Szorc
tests: add test that @commands in debugcommands.py are sorted...
r30540 ... if m:
... commands.append(m.group(1))
>>> scommands = list(sorted(commands))
>>> for i, command in enumerate(scommands):
... if command != commands[i]:
... print('commands in debugcommands.py not sorted; first differing '
... 'command is %s; expected %s' % (commands[i], command))
... break
Jun Wu
test-check-code: prevent files being added to the root directory...
r31726
Prevent adding new files in the root directory accidentally.
Yuya Nishihara
tests: alias syshg and syshgenv so they can be switched conditionally
r33199 $ testrepohg files 'glob:*'
Alex Gaynor
phabricator: include the suggested arc config in the repo...
r33584 .arcconfig
Augie Fackler
clang-format: configuration for the clang-format source formatter...
r34799 .clang-format
Jun Wu
test-check-code: prevent files being added to the root directory...
r31726 .editorconfig
.hgignore
.hgsigs
.hgtags
av6
hgweb: add .jshintrc with some basic rules...
r35163 .jshintrc
Jun Wu
test-check-code: prevent files being added to the root directory...
r31726 CONTRIBUTING
CONTRIBUTORS
COPYING
Makefile
David Demelier
doc: rename README to README.rst...
r34580 README.rst
Jun Wu
test-check-code: prevent files being added to the root directory...
r31726 hg
hgeditor
hgweb.cgi
setup.py
Yuya Nishihara
test-check-code: prevent from adding Python modules shadowed by ancient C
r37822
Prevent adding modules which could be shadowed by ancient .so/.dylib.
$ testrepohg files \
> mercurial/base85.py \
> mercurial/bdiff.py \
> mercurial/diffhelpers.py \
> mercurial/mpatch.py \
> mercurial/osutil.py \
> mercurial/parsers.py \
> mercurial/zstd.py
[1]