upstream/mercurial-mirror Files · tests/test-check-help.t

wireprotov2: implement commands as a generator of objects...

wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472

Pulkit Goyal - - Load All Authors

File last commit:

r35967:80e5210d default


                r39595:07b58266

default

Download file

             test-check-help.t
        
                    29 lines
            
             | 868 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-check-help.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Yuya Nishihara
    
help: test if "hg help TOPIC" reference is valid...

              r30880
            
      #require test-repo

        $ . "$TESTDIR/helpers-testrepo.sh"

        $ cat <<'EOF' > scanhelptopics.py

        > from __future__ import absolute_import, print_function

        > import re

        > import sys

        Matt Harbison
    
test-check-help: fix to work on Windows...

              r31498
            
        > if sys.platform == "win32":

        >     import os, msvcrt

        >     msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)

        Yuya Nishihara
    
help: test if "hg help TOPIC" reference is valid...

              r30880
            
        > topics = set()

        Pulkit Goyal
    
py3: add b'' prefixes to string literals in test files...

              r35965
            
        > topicre = re.compile(br':hg:`help ([a-z0-9\-.]+)`')

        Yuya Nishihara
    
help: test if "hg help TOPIC" reference is valid...

              r30880
            
        > for fname in sys.argv:

        Pulkit Goyal
    
py3: make sure we open the file in bytes mode...

              r35967
            
        >     with open(fname, 'rb') as f:

        Yuya Nishihara
    
help: test if "hg help TOPIC" reference is valid...

              r30880
            
        >         topics.update(m.group(1) for m in topicre.finditer(f.read()))

        > for s in sorted(topics):

        >     print(s)

        > EOF

        $ cd "$TESTDIR"/..

      Check if ":hg:`help TOPIC`" is valid:

      (use "xargs -n1 -t" to see which help commands are executed)

        Yuya Nishihara
    
tests: alias syshg and syshgenv so they can be switched conditionally

              r33199
            
        $ testrepohg files 'glob:{hgdemandimport,hgext,mercurial}/**/*.py' \

        Adam Simpkins
    
tests: use the system hg for examining the local repository...

              r33116
            
        > | sed 's|\\|/|g' \

        Augie Fackler
    
cleanup: use $PYTHON to run python in many more tests...

              r32940
            
        > | xargs $PYTHON "$TESTTMP/scanhelptopics.py" \

        Yuya Nishihara
    
help: test if "hg help TOPIC" reference is valid...

              r30880
            
        > | xargs -n1 hg help > /dev/null

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Yuya Nishihara help: test if "hg help TOPIC" reference is valid...	r30880	#require test-repo

		$ . "$TESTDIR/helpers-testrepo.sh"

		$ cat <<'EOF' > scanhelptopics.py
		> from __future__ import absolute_import, print_function
		> import re
		> import sys
Matt Harbison test-check-help: fix to work on Windows...	r31498	> if sys.platform == "win32":
		> import os, msvcrt
		> msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)
Yuya Nishihara help: test if "hg help TOPIC" reference is valid...	r30880	> topics = set()
Pulkit Goyal py3: add b'' prefixes to string literals in test files...	r35965	> topicre = re.compile(br':hg:`help ([a-z0-9\-.]+)`')
Yuya Nishihara help: test if "hg help TOPIC" reference is valid...	r30880	> for fname in sys.argv:
Pulkit Goyal py3: make sure we open the file in bytes mode...	r35967	> with open(fname, 'rb') as f:
Yuya Nishihara help: test if "hg help TOPIC" reference is valid...	r30880	> topics.update(m.group(1) for m in topicre.finditer(f.read()))
		> for s in sorted(topics):
		> print(s)
		> EOF

		$ cd "$TESTDIR"/..

		Check if ":hg:`help TOPIC`" is valid:
		(use "xargs -n1 -t" to see which help commands are executed)

Yuya Nishihara tests: alias syshg and syshgenv so they can be switched conditionally	r33199	$ testrepohg files 'glob:{hgdemandimport,hgext,mercurial}/*/.py' \
Adam Simpkins tests: use the system hg for examining the local repository...	r33116	> \| sed 's\|\\\|/\|g' \
Augie Fackler cleanup: use $PYTHON to run python in many more tests...	r32940	> \| xargs $PYTHON "$TESTTMP/scanhelptopics.py" \
Yuya Nishihara help: test if "hg help TOPIC" reference is valid...	r30880	> \| xargs -n1 hg help > /dev/null