##// END OF EJS Templates
wireprotov2: implement commands as a generator of objects...
wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472

File last commit:

r37870:8327fd79 default
r39595:07b58266 default
Show More
test-context-metadata.t
51 lines | 1.7 KiB | text/troff | Tads3Lexer
/ tests / test-context-metadata.t
Jun Wu
metadataonlyctx: don't crash when reusing the manifest with deletions...
r34001 Tests about metadataonlyctx
$ hg init
$ echo A > A
$ hg commit -A A -m 'Add A'
$ echo B > B
$ hg commit -A B -m 'Add B'
$ hg rm A
$ echo C > C
$ echo B2 > B
$ hg add C -q
$ hg commit -m 'Remove A'
$ cat > metaedit.py <<EOF
> from __future__ import absolute_import
Gregory Szorc
py3: port metaedit extension to Python 3...
r36065 > from mercurial import context, pycompat, registrar
Jun Wu
metadataonlyctx: don't crash when reusing the manifest with deletions...
r34001 > cmdtable = {}
> command = registrar.command(cmdtable)
Gregory Szorc
py3: port metaedit extension to Python 3...
r36065 > @command(b'metaedit')
Jun Wu
metadataonlyctx: don't crash when reusing the manifest with deletions...
r34001 > def metaedit(ui, repo, arg):
> # Modify commit message to "FOO"
Gregory Szorc
py3: port metaedit extension to Python 3...
r36065 > with repo.wlock(), repo.lock(), repo.transaction(b'metaedit'):
> old = repo[b'.']
> kwargs = dict(s.split(b'=', 1) for s in arg.split(b';'))
Jun Wu
metadataonlyctx: don't crash when reusing the manifest with deletions...
r34001 > if 'parents' in kwargs:
Martin von Zweigbergk
tests: pass parent revision as integer to repo[x] in test-context-metadata.t...
r37870 > kwargs[b'parents'] = map(int, kwargs[b'parents'].split(b','))
Gregory Szorc
py3: port metaedit extension to Python 3...
r36065 > new = context.metadataonlyctx(repo, old,
> **pycompat.strkwargs(kwargs))
Jun Wu
metadataonlyctx: don't crash when reusing the manifest with deletions...
r34001 > new.commit()
> EOF
$ hg --config extensions.metaedit=$TESTTMP/metaedit.py metaedit 'text=Changed'
$ hg log -r tip
changeset: 3:ad83e9e00ec9
tag: tip
parent: 1:3afb7afe6632
user: test
date: Thu Jan 01 00:00:00 1970 +0000
summary: Changed
Jun Wu
check-code: forbid "\S" in egrep regular expression...
r34063 $ hg --config extensions.metaedit=$TESTTMP/metaedit.py metaedit 'parents=0' 2>&1 | egrep '^RuntimeError'
Jun Wu
metadataonlyctx: don't crash when reusing the manifest with deletions...
r34001 RuntimeError: can't reuse the manifest: its p1 doesn't match the new ctx p1
$ hg --config extensions.metaedit=$TESTTMP/metaedit.py metaedit 'user=foo <foo@example.com>'
$ hg log -r tip
changeset: 4:1f86eaeca92b
tag: tip
parent: 1:3afb7afe6632
user: foo <foo@example.com>
date: Thu Jan 01 00:00:00 1970 +0000
summary: Remove A