upstream/mercurial-mirror Files · tests/test-hghave.t

wireprotov2: implement commands as a generator of objects...

wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472

Augie Fackler - - Load All Authors

File last commit:

r34469:bb14dbab stable


                r39595:07b58266

default

Download file

             test-hghave.t
        
                    44 lines
            
             | 975 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-hghave.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Adam Simpkins
    
tests: use the system hg for examining the local repository...

              r33116
            
        $ . "$TESTDIR/helpers-testrepo.sh"

        Matt Mackall
    
tests: unify test-hghave

              r12430
            
      Testing that hghave does not crash when checking features

        Matt Mackall
    
tests: drop explicit $TESTDIR from executables...

              r25472
            
        $ hghave --test-features 2>/dev/null

        FUJIWARA Katsunori
    
hghave: allow adding customized features at runtime...

              r25732
            
      Testing hghave extensibility for third party tools

        $ cat > hghaveaddon.py <<EOF

        > import hghave

        > @hghave.check("custom", "custom hghave feature")

        > def has_custom():

        >     return True

        > EOF

      (invocation via run-tests.py)

        $ cat > test-hghaveaddon.t <<EOF

        > #require custom

        >   $ echo foo

        >   foo

        > EOF

        Adam Simpkins
    
tests: use the system hg for examining the local repository...

              r33116
            
        $ ( \

        Yuya Nishihara
    
tests: alias syshg and syshgenv so they can be switched conditionally

              r33199
            
        > testrepohgenv; \

        Augie Fackler
    
tests: invoke run-tests.py in test-hghave using $PYTHON (issue5697)...

              r34469
            
        > $PYTHON $TESTDIR/run-tests.py $HGTEST_RUN_TESTS_PURE test-hghaveaddon.t \

        Adam Simpkins
    
tests: use the system hg for examining the local repository...

              r33116
            
        > )

        FUJIWARA Katsunori
    
hghave: allow adding customized features at runtime...

              r25732
            
        .

        Gregory Szorc
    
tests: remove support for warned tests...

              r32942
            
        # Ran 1 tests, 0 skipped, 0 failed.

        FUJIWARA Katsunori
    
hghave: allow adding customized features at runtime...

              r25732
            
      (invocation via command line)

        $ unset TESTDIR

        $ hghave custom

      (terminate with exit code 2 at failure of importing hghaveaddon.py)

        $ rm hghaveaddon.*

        $ cat > hghaveaddon.py <<EOF

        > importing this file should cause syntax error

        > EOF

        $ hghave custom

        failed to import hghaveaddon.py from '.': invalid syntax (hghaveaddon.py, line 1)

        [2]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Adam Simpkins tests: use the system hg for examining the local repository...	r33116	$ . "$TESTDIR/helpers-testrepo.sh"

Matt Mackall tests: unify test-hghave	r12430	Testing that hghave does not crash when checking features

Matt Mackall tests: drop explicit $TESTDIR from executables...	r25472	$ hghave --test-features 2>/dev/null
FUJIWARA Katsunori hghave: allow adding customized features at runtime...	r25732
		Testing hghave extensibility for third party tools

		$ cat > hghaveaddon.py <<EOF
		> import hghave
		> @hghave.check("custom", "custom hghave feature")
		> def has_custom():
		> return True
		> EOF

		(invocation via run-tests.py)

		$ cat > test-hghaveaddon.t <<EOF
		> #require custom
		> $ echo foo
		> foo
		> EOF
Adam Simpkins tests: use the system hg for examining the local repository...	r33116	$ ( \
Yuya Nishihara tests: alias syshg and syshgenv so they can be switched conditionally	r33199	> testrepohgenv; \
Augie Fackler tests: invoke run-tests.py in test-hghave using $PYTHON (issue5697)...	r34469	> $PYTHON $TESTDIR/run-tests.py $HGTEST_RUN_TESTS_PURE test-hghaveaddon.t \
Adam Simpkins tests: use the system hg for examining the local repository...	r33116	> )
FUJIWARA Katsunori hghave: allow adding customized features at runtime...	r25732	.
Gregory Szorc tests: remove support for warned tests...	r32942	# Ran 1 tests, 0 skipped, 0 failed.
FUJIWARA Katsunori hghave: allow adding customized features at runtime...	r25732
		(invocation via command line)

		$ unset TESTDIR
		$ hghave custom

		(terminate with exit code 2 at failure of importing hghaveaddon.py)

		$ rm hghaveaddon.*
		$ cat > hghaveaddon.py <<EOF
		> importing this file should cause syntax error
		> EOF

		$ hghave custom
		failed to import hghaveaddon.py from '.': invalid syntax (hghaveaddon.py, line 1)
		[2]