##// END OF EJS Templates
upstream » mercurial-mirror
RSS

Clone from https://www.mercurial-scm.org/repo/hg-all

wireprotov2: implement commands as a generator of objects...
wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472
Meirambek Omyrzak - - Load All Authors

File last commit:

r39525:f1186c29 default
r39595:07b58266 default
Show More
test-journal-exists.t
37 lines | 811 B | text/troff | Tads3Lexer
/ tests / test-journal-exists.t
History | Source | Raw |Copy content |Copy permalink
Adrian Buehlmann
tests: unify test-journal-exists
 r12205 $ hg init
$ echo a > a
$ hg ci -Am0
adding a
$ hg -q clone . foo
$ touch .hg/store/journal
$ echo foo > a
$ hg ci -Am0
Johan Bjork
journal: set Abort hint when failing due to an abandoned transaction
 r21274 abort: abandoned transaction found!
(run 'hg recover' to clean up transaction)
Matt Mackall
tests: add exit codes to unified tests
 r12316 [255]
Adrian Buehlmann
tests: unify test-journal-exists
 r12205
$ hg recover
rolling back interrupted transaction
checking changesets
checking manifests
crosschecking files in changesets and manifests
checking files
Meirambek Omyrzak
verify: make output less confusing (issue5924)...
 r39525 checked 1 changesets with 1 changes to 1 files
Adrian Buehlmann
tests: unify test-journal-exists
 r12205
Check that zero-size journals are correctly aborted:
Matt Mackall
tests: skip tests that require not having root (issue4089)...
 r20008 #if unix-permissions no-root
Adrian Buehlmann
tests: unify test-journal-exists
 r12205 $ hg bundle -qa repo.hg
$ chmod -w foo/.hg/store/00changelog.i
$ hg -R foo unbundle repo.hg
adding changesets
Mads Kiilerich
tests: remove redundant globs...
 r12640 abort: Permission denied: $TESTTMP/foo/.hg/store/.00changelog.i-* (glob)
Matt Mackall
tests: add exit codes to unified tests
 r12316 [255]
Adrian Buehlmann
tests: unify test-journal-exists
 r12205
$ if test -f foo/.hg/store/journal; then echo 'journal exists :-('; fi
Adrian Buehlmann
test-journal-exists: use #if
 r16959 #endif
Adrian Buehlmann
tests: unify test-journal-exists
 r12205